2040682 - "Open file" Toolbar item becomes greyed-out after enabling it or changing its position

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[el8]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:151.0) Gecko/20100101 Firefox/151.0

Steps to reproduce:

1. Right-click on the Toolbar and click on "Customize Toolbar...".
2. Find the "Open file" item in the items list and enable it by dragging to the Toolbar area. Click on "Done" in the bottom-right. Notice that the item is greyed-out (expected: is enabled).
3. Restart the browser. Notice that the item is now enabled, that's expected.
4. Repeat step 1 and change the item's position. The item becomes greyed-out again (expected: stays enabled).

Comment 1

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:Gijs, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

This might also be a dupe of bug 309953.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 2040682 - Remove disabled state on added toolbaritems when exiting customize mode if the underlying command is not disabled. r?Gijs!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/20e5b04212a8
https://hg.mozilla.org/integration/autoland/rev/bfe65d803bfc
Remove disabled state on added toolbaritems when exiting customize mode if the underlying command is not disabled. r=Gijs

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/10aa0d199457
https://hg.mozilla.org/integration/autoland/rev/4e60d5e637a4
Revert "Bug 2040682 - Remove disabled state on added toolbaritems when exiting customize mode if the underlying command is not disabled. r=Gijs" for causing bc failures at browser_drag_outside_palette.js

Comment 6

[rperta]

Backed out for causing bc failures at browser_drag_outside_palette.js
Backout link
Push with failures
Failure log(s)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/abcf4798d217
https://hg.mozilla.org/integration/autoland/rev/baecb60253ad
Remove disabled state on added toolbaritems when exiting customize mode if the underlying command is not disabled. r=Gijs

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/baecb60253ad

Comment 9

[BMO Github Automation]

Authored by https://github.com/mikeconley
https://github.com/mozilla/enterprise-firefox/commit/abcf4798d217a3ed5688a37d54a39f0101cb3959
[enterprise-main] Bug 2040682 - Remove disabled state on added toolbaritems when exiting customize mode if the underlying command is not disabled. r=Gijs