Closed Bug 2040756 Opened 6 months ago Closed 4 months ago

Add search input to new sidebar open tabs panel

Categories

(Firefox :: Sidebar, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
154 Branch
Tracking Status
firefox154 --- fixed

People

(Reporter: nsharpley, Assigned: dr.seed.lu, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: perf-alert, Whiteboard: [fidefe-sidebar][outreachy-sidebar-2026])

Attachments

(1 external file)

browser/components/sidebar/sidebar-opentabs.mjs

  • Add searchQuery (String) property to SidebarOpenTabs

render():

  • add moz-input-search

Test coverage:

  • Search query filters visible rows

This adds a search box to the Open Tabs sidebar panel. Typing filters the
tab rows down to those whose title or URL match, the same way the History
and Tabs from other devices panels already work. The pinned tab icons are
filtered too.

Assignee: nobody → dr.seed.lu
Status: NEW → ASSIGNED
Pushed by imoraru@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/45fcc45c2e70 https://hg.mozilla.org/integration/autoland/rev/12552966b7b4 Revert "Bug 2040756 - Add search input to new sidebar open tabs panel r=nsharpley,kcochrane" for causing multiple bc failures related to sidebar.

Revert for causing multiple bc failures related to sidebar.

Flags: needinfo?(dr.seed.lu)
Flags: needinfo?(kcochrane)
Flags: needinfo?(kcochrane)
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
Flags: needinfo?(dr.seed.lu)

Perfherder has detected a talos performance change from push 12552966b7b456fa846881b07def609af58071b6.

No action is required from the author; this comment is provided for informational purposes only.

Improvement Test Platform Options Absolute values [old vs new]
6% perf_reftest_singletons insert-subtree-not-nth-edge-has-pseudo.html (doc) macosx1470-64-shippable e10s fission stylo webrender 104.80 ms -> 98.35 ms

Need Help or Information?

If you have any questions, please reach out to bacasandrei@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: