2040764 - After a cold-start the menu shows 'Try Now' to enable the VPN before showing 'Turn on'

Status: RESOLVED DUPLICATE of bug 2041833

(Firefox for Android :: Privacy, defect)

Description

[Jonathan Almeida [:jonalmeida]]

Steps to reproduce

1. Have an account and VPN authorized on that device.
2. Ensure the VPN can turn on immediately.
3. Swipe the app away (wait a few seconds to ensure it is killed).
4. Re-open the app and immediately try to turn the VPN on.

Expected behaviour

• The VPN turns on at step 4.

Actual behaviour

• The VPN shows 'Try now' initially.
• Clicking it will show 'Turn on'
• Clicking it again will actually turn on the VPN.

Device information

• Firefox version: 153.0a1
• Android device model: All devices
• Android OS version: All versions

Any additional information?

• Unclear what is causing the race, more investigation or testing would help.

Comment 1

[Jonathan Almeida [:jonalmeida]]

This is a non-blocking bug that has a clear workaround.

Comment 2

[Jonathan Almeida [:jonalmeida]]

Attachment: potential_fix.patch

From a quick test, this seems like the right solution to rely on: we don't always get a onServiceStateChanged notification, so we should always ask the engine after we're done initializing - now we are always in the right state.

Comment 3

[Jonathan Almeida [:jonalmeida]]

This may be solved with bug 2040415.

Comment 4

[Jonathan Almeida [:jonalmeida]]

Should be fixed with bug 2041833 - the patches there cover this bug unintentionally.