Open Bug 2040792 Opened 1 day ago Updated 29 minutes ago

Remove main-thread rooting for off-thread-only debug queue check.

Categories

(Core :: JavaScript Engine, task)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
ASSIGNED

People

(Reporter: mgaudet, Assigned: mgaudet, NeedInfo)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 2040792 - Remove main-thread rooting for off-thread-only debug queue check r?arai
48 bytes, text/x-phabricator-request
Details | Review

Basically, why root if we can only call the thing that will GC after checking for main thread?

https://searchfox.org/firefox-main/rev/ada2ab816a8c8cdf48c1ccf2111ec74eaff4c7cb/js/src/builtin/Promise.cpp#1641-1651

Assignee: nobody → mgaudet
Status: NEW → ASSIGNED

Backed out for causing hazards failures on Promise.cpp.

Push with failures

Failure log

Backout link

Flags: needinfo?(mgaudet)
Pushed by csabou@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/cebc55aab4d2 https://hg.mozilla.org/integration/autoland/rev/5ebfea8c4a2f Revert "Bug 2040792 - Remove main-thread rooting for off-thread-only debug queue check r=arai" for causing hazards failures on Promise.cpp
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: