Closed
Bug 2040825
Opened 5 months ago
Closed 5 months ago
Show generic experience for eliminated teams and pass eliminated teams to SportsWidgetState
Categories
(Firefox for Android :: Homepage, task)
Tracking
()
RESOLVED
FIXED
153 Branch
People
(Reporter: skhan, Assigned: skhan)
References
Details
(Whiteboard: [fxdroid][group3][world-cup-phase2] )
Attachments
(3 external files)
Design : https://www.figma.com/design/Lmyd7U4KRQAsrhwrXQZ4mL/Mobile-Worldcup?node-id=1608-683404&m=dev
We should start showing the generic experience (no team followed) as soon as user's chosen team is eliminated.
Also pass in the eliminated teams to SportsWidgetState
Updated•5 months ago
|
Updated•5 months ago
|
Assignee: nobody → skhan
Status: NEW → ASSIGNED
Summary: Show empty placeholders for eliminated teams → Show generic experience for eliminated teams and pass eliminated teams to SportCountrySelector
Summary: Show generic experience for eliminated teams and pass eliminated teams to SportCountrySelector → Show generic experience for eliminated teams and pass eliminated teams to SportsWidgetState
Updated•5 months ago
|
Attachment #9587891 -
Attachment description: Bug 2040825 - Show empty placeholder for elimated teams and generic experience is user team is eliminated → Bug 2040825 - Show generic experience for eliminated teams and pass eliminated teams to SportCountrySelector
Pushed by skhan@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/61f3cde48f46
https://hg.mozilla.org/integration/autoland/rev/d39a9e0963f4
Show generic experience for eliminated teams and pass eliminated teams to SportCountrySelector r=android-reviewers,pollymce
Comment 3•5 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox153:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
State wiring
- New SportsWidgetAction.EliminatedCountriesUpdated(Set<String>).
- Reducer writes sportsWidgetState.eliminatedCountries.
- SportsWidgetMiddleware computes the set from every match in the latest
fetch (any SportsTeam flagged eliminated, deduped) and dispatches it
alongside MatchCardStateUpdated after each successful fetch. - The country-selector bottom sheet already consumes
sportsWidgetState.eliminatedCountries and CountryFlagItem already
greyscales eliminated flags via ColorFilter.colorMatrix — no UI
changes were needed in SportsCountrySelector.
Generic experience when all followed teams are eliminated
- SportsWidgetMiddleware.buildCards flips effectiveCodes to emptySet()
when allFollowedTeamsEliminated(result, codes) is true, routing
through buildForNoTeam so the user sees the bracket-wide view
instead of an empty team-specific pager. - The user's selection is preserved in state — they can still see and
change it via the country selector. Only the rendering switches.
Original Revision: https://phabricator.services.mozilla.com/D301451
Updated•5 months ago
|
Attachment #9589892 -
Attachment description: WIP: Bug 2040825 - Show generic experience for eliminated teams and pass eliminated teams to SportCountrySelector → Bug 2040825 - Show generic experience for eliminated teams and pass eliminated teams to SportCountrySelector
Updated•5 months ago
|
Attachment #9589892 -
Flags: approval-mozilla-beta+
Updated•5 months ago
|
status-firefox152:
--- → fixed
State wiring
- New SportsWidgetAction.EliminatedCountriesUpdated(Set<String>).
- Reducer writes sportsWidgetState.eliminatedCountries.
- SportsWidgetMiddleware computes the set from every match in the latest
fetch (any SportsTeam flagged eliminated, deduped) and dispatches it
alongside MatchCardStateUpdated after each successful fetch. - The country-selector bottom sheet already consumes
sportsWidgetState.eliminatedCountries and CountryFlagItem already
greyscales eliminated flags via ColorFilter.colorMatrix — no UI
changes were needed in SportsCountrySelector.
Generic experience when all followed teams are eliminated
- SportsWidgetMiddleware.buildCards flips effectiveCodes to emptySet()
when allFollowedTeamsEliminated(result, codes) is true, routing
through buildForNoTeam so the user sees the bracket-wide view
instead of an empty team-specific pager. - The user's selection is preserved in state — they can still see and
change it via the country selector. Only the rendering switches.
Original Revision: https://phabricator.services.mozilla.com/D301451
Updated•5 months ago
|
Attachment #9591763 -
Attachment description: WIP: Bug 2040825 - Show generic experience for eliminated teams and pass eliminated teams to SportCountrySelector → Bug 2040825 - Show generic experience for eliminated teams and pass eliminated teams to SportCountrySelector
Updated•5 months ago
|
Attachment #9591763 -
Flags: approval-mozilla-release+
Updated•5 months ago
|
status-firefox151:
--- → fixed
Updated•5 months ago
|
QA Whiteboard: [qa-triage-done-c153/b152]
You need to log in
before you can comment on or make changes to this bug.
Description
•