2041004 - Base appearance select::picker-icon

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 2

[Keith Cirkel [:keithamus]]

Attachment: Bug 2041004 - Make ::picker-icon generated content, add UA styles r?#layout

This refactors the ::picker-icon to be a generated content tree
abiding pseudo, rather than an element backed. This is in order for us
to support the specified content: UA styles.

This change also introduces said UA styles.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8ecfcdcb81cf
https://hg.mozilla.org/integration/autoland/rev/0c325edb11ed
Make ::picker-icon generated content, add UA styles r=layout-reviewers,firefox-style-system-reviewers,emilio

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/15b6e590cd47
https://hg.mozilla.org/integration/autoland/rev/db23fa3bde5c
Revert "Bug 2041004 - Make ::picker-icon generated content, add UA styles r=layout-reviewers,firefox-style-system-reviewers,emilio" for causing wpt failures

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failures

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/db23fa3bde5cce623a26ee495c2f250793579556

Push with failures

Failures log ->Assertion failure: false (MOZ_ASSERT_UNREACHABLE: Missing parent -> child link somehow?Potentially unstable ordering), at \builds\worker\checkouts\gecko\dom\base\nsContentUtils.cpp

also these mochitest plain -> https://treeherder.mozilla.org/logviewer?job_id=571384336&repo=autoland&task=D3cIVS4EQKuuoHUFzF8bXw.0&lineNumber=18044

and these reftests -> https://treeherder.mozilla.org/logviewer?job_id=571390609&repo=autoland&task=Dpx-PvQYSZuDqOFkDfOwwA.0&lineNumber=23131

and these bc failures -> https://treeherder.mozilla.org/logviewer?job_id=571385417&repo=autoland&task=OmgVMc_BRfO8HHbbRdFB8Q.0&lineNumber=8081

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e92bda8433ed
https://hg.mozilla.org/integration/autoland/rev/85f773334e3d
Make ::picker-icon generated content, add UA styles r=layout-reviewers,firefox-style-system-reviewers,emilio

Comment 7

[amarc]

Backed out for causing wr failures

• Backout link
• Push with failures
• Failure Log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e3529d76f3bc
https://hg.mozilla.org/integration/autoland/rev/73f37cd3f0a5
Make ::picker-icon generated content, add UA styles r=layout-reviewers,firefox-style-system-reviewers,emilio

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4b7b2a408389
https://hg.mozilla.org/integration/autoland/rev/c57d566ebfd0
Make ::picker-icon generated content, add UA styles r=layout-reviewers,firefox-style-system-reviewers,emilio

Comment 10

[rperta]

Backed out for causing multiple reftest failures
Backout link
Push with failures
Failure log(s)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a804178a6112
https://hg.mozilla.org/integration/autoland/rev/543d33f19d64
Make ::picker-icon generated content, add UA styles r=layout-reviewers,firefox-style-system-reviewers,emilio

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/05d92b48b080
https://hg.mozilla.org/mozilla-central/rev/8d2a24887f60
Make ::picker-icon generated content, add UA styles r=layout-reviewers,firefox-style-system-reviewers,emilio

Comment 13

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/8d2a24887f60