2041095 - Some subcategories are missing from LegacyPaneMapping

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P2)

Description

[Mark Striemer [:mstriemer]]

While reviewing bug 2039605 I went to check that the redirect is working and realized that it is missing from the LegacyPaneMappings. about:preferences#general-layout should highlight the Browser layout section, but with SRD enabled there's no redirect and nothing is highlighted

I wonder if the browser_legacy_pane_mappings.js test is finding the <setting-group data-subcategory="layout" data-srd-migrated> element and thinking that it shouldn't be migrated?

I also noticed while running the tests that the #privacy-logins redirect is tested, but it is highlighting the old groupbox. The flash of the old UI should be fixed by bug 2038570, but this should have redirected to #passwordsAutofill where that would be hidden regardless

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 2041095 - Part 1: Fix setting-group subcategories and LegacyPaneMappings tests r?#settings-reviewers!

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 2041095 - Part 2: Setup missing LegacyPaneMappings r?#settings-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dca61a5e0bef
https://hg.mozilla.org/integration/autoland/rev/7cb631890095
Part 1: Fix setting-group subcategories and LegacyPaneMappings tests r=tgiles
https://github.com/mozilla-firefox/firefox/commit/69423a8b0c15
https://hg.mozilla.org/integration/autoland/rev/a5bf0c3540fe
Part 2: Setup missing LegacyPaneMappings r=tgiles,nina-py

Comment 4

[Atila Butkovits]

Backed out for causing failures at test_setting_group.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/012d25c2aed5

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=linux%2C24.04%2Cdebug%2Cmochitests%2Cwith%2Ce10s%2Cdisabled%2Ctest-linux2404-64%2Fdebug-mochitest-chrome-1proc%2Cc&revision=9ad9ec451a1efc88542fec10b4a2aa551f00af57&selectedTaskRun=N55Rx0ZURTK5gLCuUtB5AQ.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=569062917&repo=autoland&task=N55Rx0ZURTK5gLCuUtB5AQ.0&lineNumber=3068
https://treeherder.mozilla.org/logviewer?job_id=569049542&repo=autoland&task=CAcYc4-4RU2roLABgA8Hsw.0&lineNumber=4205
https://treeherder.mozilla.org/logviewer?job_id=569077492&repo=autoland&task=IW_in9WURmycYnxgcALrEg.0&lineNumber=19070

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/7cb631890095
https://hg.mozilla.org/mozilla-central/rev/a5bf0c3540fe

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b1de473747fa
https://hg.mozilla.org/integration/autoland/rev/270bd820e8e4
Part 1: Fix setting-group subcategories and LegacyPaneMappings tests r=tgiles
https://github.com/mozilla-firefox/firefox/commit/4d41642fee08
https://hg.mozilla.org/integration/autoland/rev/3243e141cc09
Part 2: Setup missing LegacyPaneMappings r=tgiles,nina-py

Comment 7

[Silaghi Andreea]

Backed out for causing bc failures at browser/components/extensions/
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_chrome_settings_overrides_home.js | test_doorhanger_homepage_button - The correct section is spotlighted. - "homeOverride" == "homepage" - got "homeOverride", expected "homepage" (operator ==)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/22b53b6a5186
https://hg.mozilla.org/integration/autoland/rev/dd2dc9f90a9b
Part 1: Fix setting-group subcategories and LegacyPaneMappings tests r=tgiles
https://github.com/mozilla-firefox/firefox/commit/396e29116111
https://hg.mozilla.org/integration/autoland/rev/e72b757ab5f1
Part 2: Setup missing LegacyPaneMappings r=tgiles,nina-py

Comment 9

[amarc]

https://hg.mozilla.org/mozilla-central/rev/dd2dc9f90a9b
https://hg.mozilla.org/mozilla-central/rev/e72b757ab5f1

Comment 10

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:mstriemer, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox152 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Mark Striemer [:mstriemer]]

Attachment: Bug 2041095 - Part 1: Fix setting-group subcategories and LegacyPaneMappings tests

Original Revision: https://phabricator.services.mozilla.com/D301929

Comment 12

[Mark Striemer [:mstriemer]]

Attachment: Bug 2041095 - Part 2: Setup missing LegacyPaneMappings

Original Revision: https://phabricator.services.mozilla.com/D301930

Comment 13

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/a844a5a3113e
https://hg.mozilla.org/releases/mozilla-beta/rev/e675809dedbe
https://github.com/mozilla-firefox/firefox/commit/2fa3cdde9c55
https://hg.mozilla.org/releases/mozilla-beta/rev/274b5f16b979