2041355 - Downloads Settings for removing downloads is overriden when updating to Fx151

Status: VERIFIED FIXED

(Firefox for Android :: Downloads, defect, P1)

Description

[Titouan Thibaud [:titouan]]

Steps to reproduce

1. Install Fenix 150
2. Open the Downloads settings, make sure "Delete from Firefox and device" is disabled
3. Update to Fenix 151
4. Open the Downloads settings

Expected behavior

"Remove from download history" should be selected

Actual behavior

"Delete from device" is selected

Additional notes

This is confusing for users that might already be used to a specific behavior, or even worst, for users that might have intentionnaly selected this specific behavior on Fenix <151.

Comment 1

[Donal Meehan [:dmeehan]]

This sounds more like an S2? There is data loss here

Comment 2

[Titouan Thibaud [:titouan]]

I'm not fully sure Bug 2002334 is the regressor actually, I'll put it as "See also" until we know which one is the actual regressor.
We intended to keep the preference, and this settings loss might have been introduced by another patch.

Comment 3

[BugBot [:suhaib / :marco]]

The bug is marked as tracked for firefox151 (release), tracked for firefox152 (beta) and tracked for firefox153 (nightly). However, the bug still isn't assigned.

:titouan, could you please find an assignee for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 4

[Titouan Thibaud [:titouan]]

Attachment: Bug 2041355 - Set "Ask when I delete files" as the default download deletion behavior for all users.

Comment 5

[Titouan Thibaud [:titouan]]

Attachment: Bug 2041355 - Re-enable download UI tests for download deletion.

Those tests were disabled as part of D302082, and are now fixed by setting the delete behavior to DELETE_FROM_DEVICE.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/95591c7b96e2
https://hg.mozilla.org/integration/autoland/rev/b44d8bbe8ea6
Set "Ask when I delete files" as the default download deletion behavior for all users. r=android-reviewers,jdelorenzo

Comment 7

[Titouan Thibaud [:titouan]]

Attachment: Bug 2041355 - Set "Ask when I delete files" as the default download deletion behavior for all users.

We intentionally changed the value of pref_key_downloads_delete_behavior to make sure all users get this behavior, including users of a previous version where the default behavior was "remove from disk".

Original Revision: https://phabricator.services.mozilla.com/D302082

Comment 8

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: The preference for downloads deletion was overwritten by Fx151 by mistake, and is now "Delete from storage" for all users on Fx151, including the ones who were used to the settings to be "Only remove from the Fenix downloads history".
  This patch fixes that by settings the Preference to "Always ask", solving the data loss risk.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: # How to reproduce the issue: (taken from https://bugzilla.mozilla.org/show_bug.cgi?id=2041355#c0)

Steps to reproduce

1. Install Fenix 150
2. Open the Downloads settings, make sure "Delete from Firefox and device" is disabled
3. Update to Fenix 151
4. Open the Downloads settings

Expected behavior

"Remove from download history" should be selected

Actual behavior

"Delete from device" is selected

How to make sure the fix works

1. Install Fenix 150
2. Open the Downloads settings, make sure "Delete from Firefox and device" is disabled
3. Update to the build containing the patch
4. Open the Downloads settings
5. Make sure the settings is now "Ask when I delete"

• Risk associated with taking this patch: medium
• Explanation of risk level: The patch has unit tests and was tested manually by engineers working on this patch. The changes made in this patch were as minimal as possible to reduce the chance of any further issue from occurring.

But it won't have time to bake in Nightly, so I'll put the risk to Medium instead of Low.

• String changes made/needed?: No
• Is Android affected?: yes

Comment 9

[Titouan Thibaud [:titouan]]

Attachment: Bug 2041355 - Set "Ask when I delete files" as the default download deletion behavior for all users.

We intentionally changed the value of pref_key_downloads_delete_behavior to make sure all users get this behavior, including users of a previous version where the default behavior was "remove from disk".

Original Revision: https://phabricator.services.mozilla.com/D302082

Comment 10

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: The preference for downloads deletion was overwritten by Fx151 by mistake, and is now "Delete from storage" for all users on Fx151, including the ones who were used to the settings to be "Only remove from the Fenix downloads history".
  This patch fixes that by settings the Preference to "Always ask", solving the data loss risk.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: # How to reproduce the issue: (taken from https://bugzilla.mozilla.org/show_bug.cgi?id=2041355#c0)

Steps to reproduce

1. Install Fenix 150
2. Open the Downloads settings, make sure "Delete from Firefox and device" is disabled
3. Update to Fenix 151
4. Open the Downloads settings

Expected behavior

"Remove from download history" should be selected

Actual behavior

"Delete from device" is selected

How to make sure the fix works

1. Install Fenix 150
2. Open the Downloads settings, make sure "Delete from Firefox and device" is disabled
3. Update to the build containing the patch
4. Open the Downloads settings
5. Make sure the settings is now "Ask when I delete"

• Risk associated with taking this patch: medium
• Explanation of risk level: The patch has unit tests and was tested manually by engineers working on this patch. The changes made in this patch were as minimal as possible to reduce the chance of any further issue from occurring.

But it won't have time to bake in Nightly, so I'll put the risk to Medium instead of Low.

• String changes made/needed?: No
• Is Android affected?: yes

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b44d8bbe8ea6

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/822f547fb566
https://hg.mozilla.org/releases/mozilla-beta/rev/8df267a398b8

Comment 13

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/80fc6cb9e8d0
https://hg.mozilla.org/releases/mozilla-release/rev/71c6f91adac7

Comment 14

[Mira Lobontiu (Android QA)]

Verified as fixed on the Firefox for Android Nightly 153.0a1 from 5/25 with a Samsung Galaxy A56 (Android 16) - I've tested multiple scenarios:

• updated from Nightly 152.0a1 (where the default option was "Remove from download history" in Download settings) to Nightly 153.0a1 from 5/25 (the option is now "Ask when I delete files");
• downloaded files in Nightly 153.0a1 from 5/25 then selected the "delete" option - the prompt was displayed;
  ** selected from the prompt to delete also from device -> no issues;
  ** selected from the prompt to delete only from Firefox -> also no issues.

Verified as fixed on the Firefox for Android Beta 152.0b3 with a Samsung Galaxy A56 (Android 16) & a Huawei Pura 70 (Android 12) - I've tested multiple scenarios:

• updated from Beta 152.0b2 (where the default option was "Ask when I delete files" in Download settings) to Beta 152.0b3 (the option remained);
• updated from Beta 150.0b9 (where the "Delete from Firefox and device" was OFF) to Beta 152.0b3 (the default option is now "Ask when I delete files");
• downloaded files in Beta 152.0b3 then selected the "delete" option - the prompt was displayed;
  ** selected from the prompt to delete also from device -> no issues;
  ** selected from the prompt to delete only from Firefox -> also no issues.

Comment 15

[Mira Lobontiu (Android QA)]

Verified as fixed on the Firefox for Android 151.0.2 with a Samsung Galaxy A56 (Android 16) & Pixel 6 (Android 17) - I've tested multiple scenarios:

• updated from Firefox for Android 151.0 (where the default option was "Ask when I delete files" in Download settings) to Firefox for Android 151.0.2 (the option remained);
• updated from Firefox for Android 151.0 (where the "Remove from download history" was the default option) to Firefox for Android 151.0.2 (the default option is now "Ask when I delete files");
• updated from Firefox for Android 149.0 (where the "Delete from Firefox and device" was OFF) to Firefox for Android 151.0.2 (the default option is now "Ask when I delete files");
• downloaded files in Firefox for Android 151.0.2 then selected the "delete" option - the prompt was displayed:
  ** selected from the prompt to delete also from device -> no issues;
  ** selected from the prompt to delete only from Firefox -> also no issues.