Closed Bug 2041688 Opened 5 months ago Closed 5 months ago

[Homepage Sports Widget] [phase2] The Firefox logo does not change back to standard after the feature is turned OFF

Categories

(Firefox for Android :: Homepage, defect)

Firefox 153
All
Android
defect

Tracking

()

VERIFIED FIXED
153 Branch
Tracking Status
firefox151 --- verified
firefox152 --- verified
firefox153 --- verified

People

(Reporter: ljanos, Assigned: moyin)

References

Details

(Whiteboard: [fxdroid][group3][world-cup-phase2] )

Attachments

(1 file, 3 external files)

Steps to reproduce

  1. Enable "Homepage Sports Widget" feature from Secret Settings.
  2. Set the date and time of the device between 4th-10th of June 2026.
  3. Go to Settings > Homepage and turn the World cup feature OFF.
  4. Go to the Homepage and check the Firefox logo.

Expected behavior

The Firefox logo changes back to the original version.

Actual behavior

The Firefox logo does not change back to the original version, the Fifa specific logo is displayed.

Device information

  • Firefox version: Nightly 153.0a1
  • Android device model: All
  • Android OS version: All
Summary: [Homepage Sports Widget] [phase2] The Firefox logo does not change back to standard after the → [Homepage Sports Widget] [phase2] The Firefox logo does not change back to standard after the feature is turned OFF
Severity: -- → S3
Blocks: 2037222
Assignee: nobody → madeyemi
Status: NEW → ASSIGNED
Whiteboard: [fxdroid][group3][world-cup-phase2]
Pushed by madeyemi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e34afdae27b5 https://hg.mozilla.org/integration/autoland/rev/a7a9da7a541a Hide Firefox Sports logo when the sports widget is hidden r=android-reviewers,skhan
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch

{F71477898}

The previous condition only checked when the Sports Widget feature switch was enabled, and didn't check if the Sports Widget was displayed.

Also the accessibility functionality has been updated to only make the image clickable when the Sports widget is displayed, so Talkback ignores it otherwise.

Original Revision: https://phabricator.services.mozilla.com/D303070

Attachment #9591492 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: This bug fix is required for Milestone 2 of the World Cup feature
  • Code covered by automated testing?: unknown
  • Fix verified in Nightly?: no
  • Needs manual QE testing?: yes
  • Steps to reproduce for manual QE testing: Enable "Homepage Sports Widget" feature from Secret Settings.
    Set the date and time of the device between 4th-10th of June 2026.
    Go to Settings > Homepage and turn the World cup feature OFF.
    Go to the Homepage and check the Firefox logo.
  • Risk associated with taking this patch: low
  • Explanation of risk level: The feature is behind a feature flag
  • String changes made/needed?: No
  • Is Android affected?: yes
Flags: qe-verify+

Verified as fixed on the Nightly 153.0a1 build from 5/29.
While the "World cup" toggle is disabled, the logo from the homepage is the standard one, without the soccer ball.
As soon as the "World cup" toggle is enabled, the logo contains the soccer ball and when tapped the "Follow your team" sheet is displayed.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Attachment #9591492 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

{F71477898}

The previous condition only checked when the Sports Widget feature switch was enabled, and didn't check if the Sports Widget was displayed.

Also the accessibility functionality has been updated to only make the image clickable when the Sports widget is displayed, so Talkback ignores it otherwise.

Original Revision: https://phabricator.services.mozilla.com/D303070

Attachment #9591772 - Attachment description: WIP: Bug 2041688 - Hide Firefox Sports logo when the sports widget is hidden → Bug 2041688 - Hide Firefox Sports logo when the sports widget is hidden
Attachment #9591772 - Flags: approval-mozilla-release+
QA Whiteboard: [qa-triage-done-c153/b152]

Verified as fixed on the latest Firefox for Android Beta 152.0b6, and on RC 151.0.3 using a Samsung Galaxy A56 (Android 16), and an Huawei Pura 70 (Android 12).

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: