Closed Bug 2041802 Opened 5 months ago Closed 5 months ago

Pinned tabs styling for the sidebar open tabs panel

Categories

(Firefox :: Sidebar, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
153 Branch
Tracking Status
firefox153 --- fixed

People

(Reporter: nsharpley, Assigned: dr.seed.lu, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-sidebar][outreachy-sidebar-2026])

Attachments

(1 file, 1 external file)

As per the screenshot, pinned tabs should be shown as icons above the regular tabs per window, following the same pattern in Firefox View.

Pinned tabs were rendered inline with all the regular tabs. This pulls
them out into a wrapping row of favicon-only buttons at the top of the
panel, the same pattern Firefox View uses for its Open Tabs view.

  • sidebar-opentabs.mjs: adds pinnedTabItems and unpinnedTabItems
    getters and renders the pinned grid as moz-button[type="icon"]
    elements above the existing sidebar-tab-list. The list now only
    receives unpinned tabs. A #getPinnedIconSrc helper routes
    moz-remote-image: and http: favicon URLs through page-icon:, since
    the panel's CSP only allows data: and page-icon:.

  • sidebar-opentabs.css: flex-wrap layout for the new .pinned-tabs row.

  • sidebar.ftl: sidebar-opentabs-pinned-tabs string for the row's title
    attribute, with the standard noun-phrase disambiguation comment the
    other Open Tabs strings carry.

  • browser_opentabs_sidebar.js: test that pins a tab, asserts it shows
    in the pinned row and is gone from the regular list, clicks it to
    confirm activation, unpins and asserts the tab is back.

Pushed by nsharpley@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ea19940cfd80 https://hg.mozilla.org/integration/autoland/rev/e387a05c0acb Pinned tabs styling for the sidebar open tabs panel r=nsharpley,fluent-reviewers,flod
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: