2041822 - Missing support for background sending in CompleteGenericSendMessage() with mailnews.sendInBackground true

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Yury]

TB supports delayed sending via pref mailnews.sendInBackground.

Looks like the compose window won't be closed in this case:

Compare:
https://searchfox.org/comm-central/rev/07d055265b974d729a212a728af91ab167cec2b8/mail/components/compose/content/MsgComposeCommands.js#6584-6586
to:
https://searchfox.org/comm-central/rev/07d055265b974d729a212a728af91ab167cec2b8/mail/components/compose/content/MsgComposeCommands.js#6614-6615

Disclaimer: Code inspection only, not tested.

Comment 1

[Wayne Mery (:wsmwk)]

Thanks for filing the bug report and finding the regression. Removed/changed one line too many?

Also, we must be missing tests for compose with mailnews.sendInBackground=true. I wonder if anything else is broken.

Lastly, it reproduces in troubleshoot mode, where mailnews.sendInBackground shows as true. Shouldn't non-default default settings be enforced in troubleshoot mode?? Or does that only apply for settings that have UI with defaults?

Comment 2

[Wayne Mery (:wsmwk)]

With mailnews.sendInBackground=false I minimally tested mailnews.show_send_progress=false (the default is true). progress=false is typically used mailnews.sendInBackground=true. It appears to work correctly.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 2041822 - Close compose window also for background sending in CompleteGenericSendMessage() with mailnews.sendInBackground true. r=#thunderbird-reviewers

Comment 4

[Wayne Mery (:wsmwk)]

(amended) comment 1 should read "Shouldn't default settings be enforced in troubleshoot mode??"

Comment 5

[Magnus Melin [:mkmelin]]

I don't think troubleshoot mode applies default settings.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6a79df5be9c5
Close compose window also for background sending in CompleteGenericSendMessage() with mailnews.sendInBackground true. r=babolivier

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9589343 [details]
Bug 2041822 - Close compose window also for background sending in CompleteGenericSendMessage() with mailnews.sendInBackground true. r=#thunderbird-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Regression
• User impact if declined: Compose window wouldn't close after send, with the pref set
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Confined change, has a test
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: none

Comment 8

[Corey Bryant]

Comment on attachment 9589343 [details]
Bug 2041822 - Close compose window also for background sending in CompleteGenericSendMessage() with mailnews.sendInBackground true. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 9

[Evandro Baginski [:ebaginski]]

Thunderbird 152.0b3
https:/hg.mozilla.org/releases/comm-beta/rev/08e7e24ff8c9

Comment 11

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Confirming this issue as verified fixed with 154.0a1(20260712081932) and 153.0b7(20260708174053). Verified using macOS 15/26, Win11 and Ubuntu 24.

Comment 12

[Francesco (no longer active, use PM for contact)]

Bulk added status-thunderbird-esr153=affected where only status-thunderbird153=affected was set.

Comment 13

[Wayne Mery (:wsmwk)]

Target milestone already v153