2041837 - line colored as failure in log viewer different from listed failure lines

Status: NEW

(Tree Management :: Treeherder: Frontend, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This issue had been observed before the log viewer had been replaced but it feels like this is more frequent now:
A line in the log viewer has red background but the actual failure line (also listed at the top right) can be found at an offset of a few lines.
Example: https://treeherder.mozilla.org/logviewer?job_id=568203756&repo=try&task=bxdkYws_Tfybg-Iquljfmw.0&lineNumber=43284 - offset of two lines.

Comment 1

[Cameron Dawson [:camd]]

The line splitting mechanism changed in the new logviewer. The old one wasn't perfect, but the newer one made it worse. This PR fixes it: https://github.com/mozilla/treeherder/pull/9549