libwebrtc vendor-pin lag: 2 confirmed + 6 suspected unpatched Chrome 148 WebRTC CVEs (CVE-2026-9111 Critical UAF, CVE-2026-9120 High UAF)
Categories
(Core :: WebRTC, defect)
Tracking
()
People
(Reporter: adq7106, Assigned: mjf)
References
Details
(Keywords: reporter-external, sec-high, Whiteboard: [adv-main152+][adv-esr140.12+])
Attachments
(10 external files, 1 obsolete file)
Steps to reproduce:
Vendor-Pin Lag Analysis
Firefox's vendored libwebrtc (third_party/libwebrtc/) is pinned to WebRTC M148 branch commit 9600e77d854090669817d22aa2fc941ee92aaacd, last vendored on 2026-04-22.
Between that date and 2026-05-24, Chrome 148 stable channel has published 9 WebRTC CVEs across 3 patch releases. Of these, 1 (CVE-2026-9119, Bug chromium:502661101) is likely already fixed in Firefox — its fix commit 9c2497e landed on M148 Apr 20, before Firefox's pin.
Of the remaining 8, 2 have confirmed post-pin fix CLs (CVE-2026-9111 → 6316b66d, CVE-2026-9120 → 9a7f650b) and 6 are suspected unpatched with fix CLs not yet mapped.
Evidence
- Firefox pin: README.mozilla.last-vendor = 9600e77d85, vendored 2026-04-22 (verified on mozilla-central + mozilla-beta via hg-edge.mozilla.org)
- M148 branch log: 7 post-pin commits from webrtc.googlesource.com/src/+log/branch-heads/7778
- CVE descriptions: 9 WebRTC CVEs surveyed from CVE.org (cveawg.mitre.org API)
- Chrome schedule: Chromium Dash confirms M148 stable release Tue, May 5, 2026
- No observed cherry-pick: moz-patch-stack/ (568 patches) contains no entries targeting the 7 post-pin hashes
Tier 1 — Confirmed post-pin (fix CL identified)
| CVE | Bug ID | Class | Severity | Fix CL | Fix date |
|---|---|---|---|---|---|
| CVE-2026-9111 | 504551032 | UAF (Linux) | Critical | 6316b66d | Apr 28 |
| CVE-2026-9120 | 504620824 | UAF | High | 9a7f650b | May 01 |
Reachability:
- CVE-2026-9111: Linux + screen-sharing permission (Pipewire desktop capture)
- CVE-2026-9120: getUserMedia + video encoding (VideoEncoder lifecycle)
Tier 2 — Suspected (fix CL not mapped)
| CVE | Bug ID | Class | Severity | Chrome release |
|---|---|---|---|---|
| CVE-2026-7928 | 504612429 | UAF (Windows) | High | 148.0.7778.96 (May 5) |
| CVE-2026-7951 | 496266456 | OOB write | Medium | 148.0.7778.96 |
| CVE-2026-7987 | 498696266 | UAF | Medium | 148.0.7778.96 |
| CVE-2026-7988 | 498753456 | Type confusion | Medium | 148.0.7778.96 |
| CVE-2026-8016 | 497695401 | UAF | Low | 148.0.7778.96 |
| CVE-2026-8526 | 486536241 | OOB write | High | 148.0.7778.167/.168 (May 12) |
Pre-pin fixed
| CVE | Bug ID | Fix CL | Status |
|---|---|---|---|
| CVE-2026-9119 | 502661101 | 9c2497e (Apr 20) | Firefox HAS this fix |
M148 Branch Commits After Firefox Pin
7 commits between pin (Apr 22 10:08 UTC) and M148 HEAD:
- 6316b66 Apr 28 — [Pipewire] Fix mouse cursor data race
- 9a7f650 May 01 — Always release VideoEncoders before destruction
- 305a870 May 19 — Refactor RTP header extension ID allocation
- d46237a May 20 — Validate CGImage dimensions in MouseCursorMonitorMac
- 26c6538 May 20 — Guard RestoreTokenManager add/reads with Mutex
- ac8b001 May 20 — Fix TOCTOU race in CroppingWindowCapturer
- e3ee869 May 22 — In SctpDataChannel use plain bool as safety flag
Branch ordering verified via webrtc.googlesource.com/src/+log/branch-heads/7778?format=JSON.
Methodology
This is a vendor-pin-lag evidence report. The vulnerability classes (UAF, OOB write, type confusion) are established by Chrome's CVE disclosures. Firefox inherits the same codebase via vendoring. This analysis was conducted with AI assistance (Claude). All factual claims are verified against primary sources listed above.
Actual results:
Firefox 151.0.1 stable (and 152 nightly/beta) ships libwebrtc pinned to M148 commit 9600e77d85 from 2026-04-22. At least 2 Chrome 148 WebRTC CVEs (CVE-2026-9111 Critical UAF, CVE-2026-9120 High UAF) have confirmed fix CLs that landed on the M148 branch AFTER Firefox's pin date. 6 additional WebRTC CVEs are suspected unpatched. The 7 post-pin M148 commits are absent from Firefox's moz-patch-stack.
Expected results:
Firefox should re-vendor libwebrtc against M148 branch HEAD to include all 7 post-pin security commits. Recommended command: ./mach python dom/media/webrtc/third_party_build/vendor-libwebrtc.py --from-local <moz-libwebrtc-path> --commit mozpatches libwebrtc
Updated•5 months ago
|
| Assignee | ||
Comment 1•5 months ago
•
|
||
Yep - this mostly matches my data (using new detection scripts) with the exception that 6316b66 Apr 28 — [Pipewire] Fix mouse cursor data race was already handled in Bug 2029447.
| Assignee | ||
Updated•5 months ago
|
| Assignee | ||
Comment 2•5 months ago
|
||
Upstream commit: https://webrtc.googlesource.com/src/+/9a7f650bcd14f241d20f88f4e1ea3b7300de72ac
[M148] Always release VideoEncoders before destruction.
Original change's description:
> Always release VideoEncoders before destruction.
>
> Without a `Release()` call there is a potential for race conditions
> between asynchronous encoder callbacks and the destructor sequence.
>
> Bug: chromium:504620824
> Change-Id: I1fba23ef3a4a238503cdf8d2ea5831e815d7b902
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/465582
> Auto-Submit: Erik Språng <sprang@webrtc.org>
> Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
> Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
> Commit-Queue: Erik Språng <sprang@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#47495}
(cherry picked from commit 21d9744bd599d106da9171fbb1ed09047d7178ca)
Bug: chromium:505251595,chromium:504620824
Change-Id: I1fba23ef3a4a238503cdf8d2ea5831e815d7b902
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/468940
Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7778@{#7}
Cr-Branched-From: ca896b7ffef011bbf6957c99d413c5aac602c99f-refs/heads/main@{#47319}
Updated•5 months ago
|
| Assignee | ||
Comment 3•5 months ago
|
||
Upstream commit: https://webrtc.googlesource.com/src/+/305a870932d9c9de4bbfe3814d4946b2f6cf2c60
[M148] Refactor RTP header extension ID allocation to be persistent and shared.
Original change's description:
> Refactor RTP header extension ID allocation to be persistent and shared.
>
> - Introduced RtpHeaderExtensionRecorder and RtpHeaderExtensionPicker in
> call/payload_type_picker.
> - Added SuggestRtpHeaderExtensionId and AddRtpHeaderExtensionMapping to
> PayloadTypeSuggester interface.
> - Implemented persistent RTP header extension ID mapping in
> SdpPayloadTypeSuggester.
> - Refactored pc/media_session.cc to use PayloadTypeSuggester for all
> RTP header extension ID allocations, replacing UsedRtpHeaderExtensionIds.
> - Ensured shared mapping between local and remote extensions for the
> same transport.
> - Maintained RFC 8285 compliance for one-byte and two-byte ID allocation.
> - Updated tests to explicitly allow mixed extensions when two-byte IDs
> are expected.
> - Removed obsolete UsedRtpHeaderExtensionIds and its unit test.
>
> Bug: webrtc:503013383
> Change-Id: Ic98522b1eec52c736a73bd034493f19ac6524b5a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/465300
> Auto-Submit: Harald Alvestrand <hta@webrtc.org>
> Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#47492}
(cherry picked from commit d1ae1e9ad4d183f4b00ad0962b35bba90162f038)
Bug: webrtc:503013383
Bug: chromium:513880244
Fixed: chromium:514078702
No-Try: true
Change-Id: If466bf7fa67e1277bcdd6b8af8c4f175ad0c9df7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/472720
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/branch-heads/7778@{#8}
Cr-Branched-From: ca896b7ffef011bbf6957c99d413c5aac602c99f-refs/heads/main@{#47319}
Updated•5 months ago
|
| Assignee | ||
Comment 4•5 months ago
|
||
Upstream commit: https://webrtc.googlesource.com/src/+/d46237a72ede7294840c375bed7b9df6f60cdca7
[M148] Validate CGImage dimensions in MouseCursorMonitorMac
Original change's description:
> Validate CGImage dimensions in MouseCursorMonitorMac
>
> This adds missing height checks alongside the existing width checks
> when processing and scaling the cursor image.
>
> Fixed: chromium:513268100
> Change-Id: Ida1e58334a9d3bda429819e4af51b33afbd0a95d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/472700
> Reviewed-by: Alexander Cooper <alcooper@chromium.org>
> Auto-Submit: Johannes Kron <kron@webrtc.org>
> Commit-Queue: Alexander Cooper <alcooper@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#47715}
(cherry picked from commit b343cd4e280980f26b4feb80684f57d5b4324e12)
Bug: chromium:514925120,chromium:513268100
Change-Id: Ida1e58334a9d3bda429819e4af51b33afbd0a95d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/473980
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7778@{#9}
Cr-Branched-From: ca896b7ffef011bbf6957c99d413c5aac602c99f-refs/heads/main@{#47319}
Updated•5 months ago
|
| Assignee | ||
Comment 5•5 months ago
|
||
Upstream commit: https://webrtc.googlesource.com/src/+/26c6538381a19e8ed58af0c22068db9f050d2967
[M148] Guard RestoreTokenManager add/reads with Mutex
Original change's description:
> Guard RestoreTokenManager add/reads with Mutex
>
> The RestoreTokenManager is a singleton who's adds and reads could be
> accessed by multiple threads simultaneously. To prevent any potential
> issues/collisions, ensure that such accesses happen behind a lock.
>
> Bug: chromium:513049286
> Change-Id: I44c1c7977a6d02e1ac3fbe00e6ffc7bc22e41e46
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/472480
> Reviewed-by: Mark Foltz <mfoltz@chromium.org>
> Auto-Submit: Alexander Cooper <alcooper@chromium.org>
> Commit-Queue: Mark Foltz <mfoltz@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#47711}
(cherry picked from commit b9f0b184cb5a487fcb4910efaf4f84483ddba284)
Bug: chromium:514926739,chromium:513049286
Change-Id: I44c1c7977a6d02e1ac3fbe00e6ffc7bc22e41e46
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/474060
Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7778@{#10}
Cr-Branched-From: ca896b7ffef011bbf6957c99d413c5aac602c99f-refs/heads/main@{#47319}
Updated•5 months ago
|
| Assignee | ||
Comment 6•5 months ago
|
||
Upstream commit: https://webrtc.googlesource.com/src/+/ac8b0016a84a52407e52b92af0671ed23196202c
[M148] [desktop capture] Fix TOCTOU race condition in CroppingWindowCapturer.
Original change's description:
> [desktop capture] Fix TOCTOU race condition in CroppingWindowCapturer.
>
> Crop the frame using the window rectangle captured when the capture
> was initiated, rather than re-querying the rectangle after the capture
> finishes.
>
> Bug: chromium:504557432
> Change-Id: I459d528ac343163fde9a9dbf6c40a542c1a04c61
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/467820
> Reviewed-by: Stefan Holmer <stefan@webrtc.org>
> Reviewed-by: Alexander Cooper <alcooper@chromium.org>
> Commit-Queue: Mark Foltz <mfoltz@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#47575}
(cherry picked from commit 22f071a33eb46cbabcbf05961127dde7a2e3d908)
Bug: chromium:514924157,chromium:504557432
Change-Id: I459d528ac343163fde9a9dbf6c40a542c1a04c61
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/474160
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/branch-heads/7778@{#11}
Cr-Branched-From: ca896b7ffef011bbf6957c99d413c5aac602c99f-refs/heads/main@{#47319}
Updated•5 months ago
|
| Assignee | ||
Comment 7•5 months ago
|
||
Upstream commit: https://webrtc.googlesource.com/src/+/e3ee86921c57b9f8921045e77f098604803cb66c
[M148] In SctpDataChannel use plain bool as safety flag.
Original change's description:
> In SctpDataChannel use plain bool as safety flag.
>
> SctpDataChannel can be destroyed on various threads and thus safety flag
> couldn't be properly invalidated in the destructor. Instead of relying
> on it when posting async send, rely on reference counting of the full
> object
>
> Bug: chromium:504716948
> Change-Id: I1246fecac26d0761be006b069658d072183546bf
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/469980
> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#47635}
(cherry picked from commit 9b4ffb3281c02327968ed07389082fcb2dd77baa)
Bug: chromium:514923643,chromium:504716948
Change-Id: I1246fecac26d0761be006b069658d072183546bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/474800
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/branch-heads/7778@{#12}
Cr-Branched-From: ca896b7ffef011bbf6957c99d413c5aac602c99f-refs/heads/main@{#47319}
Updated•5 months ago
|
Updated•5 months ago
|
Comment 8•5 months ago
|
||
Bug 2040478 will handle 153.
Comment 9•5 months ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined/Reason for urgency: UAF and/or OOB fixes from upstream libwebrtc with CVEs that could be exploited.
- Code covered by automated testing?: yes
- Fix verified in Nightly?: yes
- Needs manual QE testing?: no
- Steps to reproduce for manual QE testing:
- Risk associated with taking this patch: low
- Explanation of risk level: These are all commits used by upstream libwebrtc.
- String changes made/needed?: n/a
- Is Android affected?: yes
Comment 10•5 months ago
|
||
We'll want to uplift these to ESR140 also I assume - please go ahead add nominations if so. I'm calling ESR115 wontfix for this bug as presumably these fixes will roll up under the wider initiative for backporting fixes to that branch at some later point.
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Comment 11•5 months ago
|
||
| uplift | ||
Comment 12•5 months ago
|
||
Backed out for Linux build bustage.
https://treeherder.mozilla.org/logviewer?job_id=569402250&repo=mozilla-beta&task=HWxTqg3iQZ2bTSLdA8DOaA.0&lineNumber=55249
ERROR - /builds/worker/checkouts/gecko/third_party/libwebrtc/rtc_base/containers/flat_tree.h:458:14: error: no matching function for call to object of type 'const key_compare' (aka 'const std::less<void>')
INFO - 458 | return comp_(extract_if_value_type(lhs), extract_if_value_type(rhs));
INFO - | ^~~~~
Comment 13•5 months ago
|
||
| backout uplift | ||
| Assignee | ||
Comment 14•5 months ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #10)
We'll want to uplift these to ESR140 also I assume - please go ahead add nominations if so. I'm calling ESR115 wontfix for this bug as presumably these fixes will roll up under the wider initiative for backporting fixes to that branch at some later point.
I'm currently working on the esr140 patches - they don't apply cleanly as is. Leaving the NI so I don't forget to fix the back-out issue.
Updated•5 months ago
|
| Assignee | ||
Comment 15•5 months ago
|
||
Upstream commit: https://webrtc.googlesource.com/src/+/9a7f650bcd14f241d20f88f4e1ea3b7300de72ac
[M148] Always release VideoEncoders before destruction.
Original change's description:
> Always release VideoEncoders before destruction.
>
> Without a `Release()` call there is a potential for race conditions
> between asynchronous encoder callbacks and the destructor sequence.
>
> Bug: chromium:504620824
> Change-Id: I1fba23ef3a4a238503cdf8d2ea5831e815d7b902
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/465582
> Auto-Submit: Erik Språng <sprang@webrtc.org>
> Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
> Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
> Commit-Queue: Erik Språng <sprang@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#47495}
(cherry picked from commit 21d9744bd599d106da9171fbb1ed09047d7178ca)
Bug: chromium:505251595,chromium:504620824
Change-Id: I1fba23ef3a4a238503cdf8d2ea5831e815d7b902
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/468940
Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7778@{#7}
Cr-Branched-From: ca896b7ffef011bbf6957c99d413c5aac602c99f-refs/heads/main@{#47319}
Updated•5 months ago
|
| Assignee | ||
Comment 16•5 months ago
|
||
and needed to properly build:
Cherry-pick upstream libwebrtc commit e26f1de971
Cherry-pick upstream libwebrtc commit 71434c0a5e
Upstream commit: https://webrtc.googlesource.com/src/+/305a870932d9c9de4bbfe3814d4946b2f6cf2c60
[M148] Refactor RTP header extension ID allocation to be persistent and shared.
Original change's description:
> Refactor RTP header extension ID allocation to be persistent and shared.
>
> - Introduced RtpHeaderExtensionRecorder and RtpHeaderExtensionPicker in
> call/payload_type_picker.
> - Added SuggestRtpHeaderExtensionId and AddRtpHeaderExtensionMapping to
> PayloadTypeSuggester interface.
> - Implemented persistent RTP header extension ID mapping in
> SdpPayloadTypeSuggester.
> - Refactored pc/media_session.cc to use PayloadTypeSuggester for all
> RTP header extension ID allocations, replacing UsedRtpHeaderExtensionIds.
> - Ensured shared mapping between local and remote extensions for the
> same transport.
> - Maintained RFC 8285 compliance for one-byte and two-byte ID allocation.
> - Updated tests to explicitly allow mixed extensions when two-byte IDs
> are expected.
> - Removed obsolete UsedRtpHeaderExtensionIds and its unit test.
>
> Bug: webrtc:503013383
> Change-Id: Ic98522b1eec52c736a73bd034493f19ac6524b5a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/465300
> Auto-Submit: Harald Alvestrand <hta@webrtc.org>
> Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#47492}
(cherry picked from commit d1ae1e9ad4d183f4b00ad0962b35bba90162f038)
Bug: webrtc:503013383
Bug: chromium:513880244
Fixed: chromium:514078702
No-Try: true
Change-Id: If466bf7fa67e1277bcdd6b8af8c4f175ad0c9df7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/472720
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/branch-heads/7778@{#8}
Cr-Branched-From: ca896b7ffef011bbf6957c99d413c5aac602c99f-refs/heads/main@{#47319}
Upstream commit: https://webrtc.googlesource.com/src/+/e26f1de971edd0d26a19c788fbe09ce1d5cfb865
Remove a PT handling that had no effect
This code block was found to have no effect on PT mapping.
Submitting as a separate CL in order to ensure no side effects.
Bug: webrtc:360058654
Change-Id: Ie25d7d6c1b39c4705a3277edaad8e1cf44483306
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/429342
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#46350}
Upstream commit: https://webrtc.googlesource.com/src/+/71434c0a5e66602c7a79a2ad52e15f35f6369df6
Remove JsepTransportController's PayloadTypeSuggester
Also remove functions that were only called from that.
Bug: webrtc:360058654
Change-Id: I7a4e3a5f4c65f586f002dfdc35d927c74ad3fff5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/429344
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#46394}
Updated•5 months ago
|
| Assignee | ||
Comment 17•5 months ago
|
||
Upstream commit: https://webrtc.googlesource.com/src/+/d46237a72ede7294840c375bed7b9df6f60cdca7
[M148] Validate CGImage dimensions in MouseCursorMonitorMac
Original change's description:
> Validate CGImage dimensions in MouseCursorMonitorMac
>
> This adds missing height checks alongside the existing width checks
> when processing and scaling the cursor image.
>
> Fixed: chromium:513268100
> Change-Id: Ida1e58334a9d3bda429819e4af51b33afbd0a95d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/472700
> Reviewed-by: Alexander Cooper <alcooper@chromium.org>
> Auto-Submit: Johannes Kron <kron@webrtc.org>
> Commit-Queue: Alexander Cooper <alcooper@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#47715}
(cherry picked from commit b343cd4e280980f26b4feb80684f57d5b4324e12)
Bug: chromium:514925120,chromium:513268100
Change-Id: Ida1e58334a9d3bda429819e4af51b33afbd0a95d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/473980
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7778@{#9}
Cr-Branched-From: ca896b7ffef011bbf6957c99d413c5aac602c99f-refs/heads/main@{#47319}
Updated•5 months ago
|
| Assignee | ||
Comment 18•5 months ago
|
||
Upstream commit: https://webrtc.googlesource.com/src/+/26c6538381a19e8ed58af0c22068db9f050d2967
[M148] Guard RestoreTokenManager add/reads with Mutex
Original change's description:
> Guard RestoreTokenManager add/reads with Mutex
>
> The RestoreTokenManager is a singleton who's adds and reads could be
> accessed by multiple threads simultaneously. To prevent any potential
> issues/collisions, ensure that such accesses happen behind a lock.
>
> Bug: chromium:513049286
> Change-Id: I44c1c7977a6d02e1ac3fbe00e6ffc7bc22e41e46
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/472480
> Reviewed-by: Mark Foltz <mfoltz@chromium.org>
> Auto-Submit: Alexander Cooper <alcooper@chromium.org>
> Commit-Queue: Mark Foltz <mfoltz@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#47711}
(cherry picked from commit b9f0b184cb5a487fcb4910efaf4f84483ddba284)
Bug: chromium:514926739,chromium:513049286
Change-Id: I44c1c7977a6d02e1ac3fbe00e6ffc7bc22e41e46
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/474060
Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7778@{#10}
Cr-Branched-From: ca896b7ffef011bbf6957c99d413c5aac602c99f-refs/heads/main@{#47319}
Updated•5 months ago
|
| Assignee | ||
Comment 19•5 months ago
|
||
Upstream commit: https://webrtc.googlesource.com/src/+/ac8b0016a84a52407e52b92af0671ed23196202c
[M148] [desktop capture] Fix TOCTOU race condition in CroppingWindowCapturer.
Original change's description:
> [desktop capture] Fix TOCTOU race condition in CroppingWindowCapturer.
>
> Crop the frame using the window rectangle captured when the capture
> was initiated, rather than re-querying the rectangle after the capture
> finishes.
>
> Bug: chromium:504557432
> Change-Id: I459d528ac343163fde9a9dbf6c40a542c1a04c61
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/467820
> Reviewed-by: Stefan Holmer <stefan@webrtc.org>
> Reviewed-by: Alexander Cooper <alcooper@chromium.org>
> Commit-Queue: Mark Foltz <mfoltz@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#47575}
(cherry picked from commit 22f071a33eb46cbabcbf05961127dde7a2e3d908)
Bug: chromium:514924157,chromium:504557432
Change-Id: I459d528ac343163fde9a9dbf6c40a542c1a04c61
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/474160
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/branch-heads/7778@{#11}
Cr-Branched-From: ca896b7ffef011bbf6957c99d413c5aac602c99f-refs/heads/main@{#47319}
Updated•5 months ago
|
Comment 20•5 months ago
|
||
firefox-esr140 Uplift Approval Request
- User impact if declined/Reason for urgency: UAF and/or OOB fixes from upstream libwebrtc with CVEs that could be exploited.
- Code covered by automated testing?: yes
- Fix verified in Nightly?: yes
- Needs manual QE testing?: no
- Steps to reproduce for manual QE testing:
- Risk associated with taking this patch: low
- Explanation of risk level: These are all commits used by upstream libwebrtc.
- String changes made/needed?: n/a
- Is Android affected?: yes
Comment 21•5 months ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined/Reason for urgency: UAF and/or OOB fixes from upstream libwebrtc with CVEs that could be exploited.
- Code covered by automated testing?: yes
- Fix verified in Nightly?: yes
- Needs manual QE testing?: no
- Steps to reproduce for manual QE testing:
- Risk associated with taking this patch: low
- Explanation of risk level: These are all commits used by upstream libwebrtc.
- String changes made/needed?: n/a
- Is Android affected?: yes
Updated•5 months ago
|
Comment 22•5 months ago
|
||
| uplift | ||
| Assignee | ||
Comment 23•5 months ago
|
||
For posterity, the e3ee869 May 22 — In SctpDataChannel use plain bool as safety flag commit is not needed because we don't build the pc (peerconnection) directory in libwebrtc.
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Comment 24•5 months ago
|
||
| uplift | ||
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
| Reporter | ||
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Comment 25•4 months ago
|
||
| bounty-note | ||
We have a regular process to update this library and incorporate upstream security fixes. It would be nice if it were more often, but we have to balance the stability risks of taking untested revisions against the patch gap. Our bug bounty program considers these upstream bugs as "known issues" for libraries where we have such a process that ensures Firefox will receive the patches. This does not apply to all libraries -- there are many that are relatively stable and therefore don't get regularly updated by us.
However, it does appear we don't have such a regular process for identifying and backporting security fixes in this library, so we do believe this bug identified a gap that is eligible for our bounty program.
Updated•1 month ago
|
Description
•