2042044 - Move per-rect snapping from scene build to frame build

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Comment 1

[Glenn Watson [:gw]]

Attachment: Bug 2042044 - Move per-rect snapping from scene build to frame build.

This does most of the mechanical work to move snapping from the
scene building pass in to frame building. It keeps the existing
snap logic to retain current behavior (follow up commits will
change the way the snapping logic itself works).

There are a few TODO comments in this patch related to maintaining
the existing behavior which will disappear in follow up commits
that change the snapping logic itself.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8b5e80832fc4
https://hg.mozilla.org/integration/autoland/rev/a2d750604f68
Move per-rect snapping from scene build to frame build. r=gfx-reviewers,nical

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/26d376a17759
https://hg.mozilla.org/integration/autoland/rev/250609646935
Revert "Bug 2042044 - Move per-rect snapping from scene build to frame build. r=gfx-reviewers,nical" for causing wr failures at webkit-box-rtl-flex.html

Comment 4

[rperta]

Backed out for causing wr failures at webkit-box-rtl-flex.html
Backout link
Push with failures
Failure log(s)

Comment 5

[Glenn Watson [:gw]]

Updated fuzziness for the linked regression, and restored the FAIL annotation on android for the test that now passes on Linux.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6c213595d4e8
https://hg.mozilla.org/integration/autoland/rev/1473307e3b99
Move per-rect snapping from scene build to frame build. r=gfx-reviewers,nical

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9451c33b3462
https://hg.mozilla.org/integration/autoland/rev/9d9a98070916
Revert "Bug 2042044 - Move per-rect snapping from scene build to frame build. r=gfx-reviewers,nical" for causing wr failures at webkit-box-rtl-flex.html

Comment 8

[rperta]

Backed out for causing wr failures at webkit-box-rtl-flex.html
Backout link
Push with failures
Failure log(s)

Comment 9

[Glenn Watson [:gw]]

Updated android expectations and will try reland now.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b81158da5bde
https://hg.mozilla.org/integration/autoland/rev/cd6f7923ddae
Move per-rect snapping from scene build to frame build. r=gfx-reviewers,nical

Comment 11

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/cd6f7923ddae