2042048 - Make selectors crate lighterweight with default features disabled

Status: ASSIGNED

(Core :: CSS Parsing and Computation, task)

Description

[Nico Burns]

This change is targeted at external users of the selectors crate who may wish to trade-off some runtime performance in favour of a lighter dependency tree. Gecko will continue to enable default features which will mean it is entirely unnaffected by these changes.

This is a selectors companion to this cssparser PR: https://github.com/servo/rust-cssparser/pull/425

Comment 1

[Nico Burns]

Attachment: Bug 2042048: Eliminate derive_more dependency from selectors (r=#style)

This was only being used for 2 impls which are now hand-written.

Signed-off-by: Nico Burns <[e-mail]>

Comment 2

[Nico Burns]

Attachment: Bug 2042048: Make selectors dependency on cssparser default features optional (r=#style)

Signed-off-by: Nico Burns <[e-mail]>

Comment 3

[Nico Burns]

Attachment: Bug 2042048: Make selectors's dependency on phf optional (r=#style)

Signed-off-by: Nico Burns <[e-mail]>

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a8d2febb7c39
https://hg.mozilla.org/integration/autoland/rev/5c1a91690653
Eliminate derive_more dependency from selectors (r=firefox-style-system-reviewers,emilio)
https://github.com/mozilla-firefox/firefox/commit/f8907cacc849
https://hg.mozilla.org/integration/autoland/rev/61e590e59c9c
Make selectors dependency on cssparser default features optional (r=firefox-style-system-reviewers,emilio)
https://github.com/mozilla-firefox/firefox/commit/cf88a7561f98
https://hg.mozilla.org/integration/autoland/rev/64d2c3076cf7
Make selectors's dependency on phf optional (r=firefox-style-system-reviewers,emilio)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/03bc66369e27
https://hg.mozilla.org/integration/autoland/rev/facdc6f04ebe
Revert "Bug 2042048: Make selectors's dependency on phf optional (r=firefox-style-system-reviewers,emilio)" for causing build bustages

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/facdc6f04ebe58e46db62420c4ad0e37b161842a

Push with failures

Failures log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5da7fb9d3f91
https://hg.mozilla.org/integration/autoland/rev/80f413f98f64
Eliminate derive_more dependency from selectors (r=firefox-style-system-reviewers,emilio)
https://github.com/mozilla-firefox/firefox/commit/370e53672d01
https://hg.mozilla.org/integration/autoland/rev/8bb3d75079ef
Make selectors dependency on cssparser default features optional (r=firefox-style-system-reviewers,emilio)
https://github.com/mozilla-firefox/firefox/commit/a47c76d17ece
https://hg.mozilla.org/integration/autoland/rev/6a903d4a58e3
Make selectors's dependency on phf optional (r=firefox-style-system-reviewers,emilio,dshin)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0eaf6473d8e8
https://hg.mozilla.org/integration/autoland/rev/0166928073c1
Revert "Bug 2042048: Make selectors's dependency on phf optional (r=firefox-style-system-reviewers,emilio,dshin)" for causing br bustages

Comment 9

[amarc]

Backed out for causing br bustages

• Backout link
• Push with failures
• Failure Log
• Failure Log 2
• Failure Log 3
• Failure Log 4
• Failure Log 5

Comment 10

[BugBot [:suhaib / :marco]]

There are some r+ patches which didn't land and no activity in this bug for 1 week.
:nico, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.