2042068 - Clear the tracking db when history is cleared

Status: RESOLVED FIXED

(Firefox for Android :: Privacy, task)

Description

[Petru-Mugurel Lingurar [:petru]]

Similar to the desktop functionality where the details about blocked trackers are also cleared when

• history is cleared or
• history and downloads are cleared

On Fenix we should also request Gecko to clear the tracking db details whenever deleting all browsing history.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 2042068 - part 1 - Add a new clearTrackingDb API to GeckoView r=#android-reviewers

This will allow clearing all persisted data about blocked trackers in previous
browsing sessions.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 2042068 - part 2 - Clear trackers data when browsing history is cleared r=#android-reviewers

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 2042068 - part 3 - Decouple DeleteBrowsingDataController from the menu fragment lifecycle r=#android-reviewers

The controller was instantiated in MenuDialogFragment with
coroutineContext = lifecycleScope.coroutineContext which carries
the fragment's Job.
The "Delete browsing data and quit" flow dismisses the fragment
before clearBrowsingDataOnQuit completes, which cancels that Job.
Every subsequent withContext(coroutineContext) inside the
controller's delete methods then throws CancellationException before
entering its lambda potentially skipping the engine clear calls for
tracker data, cookies, cache, and site permissions.

Pass Dispatchers.Main instead. It carries no Job, so the engine calls
inherit the still-alive activity-scoped coroutine's Job and run as
expected during the quit path.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1f993d230598
https://hg.mozilla.org/integration/autoland/rev/eec9088b9ed3
part 1 - Add a new clearTrackingDb API to GeckoView r=android-reviewers,geckoview-reviewers,geckoview-api-reviewers,ohall,nalexander
https://github.com/mozilla-firefox/firefox/commit/de1260f6382d
https://hg.mozilla.org/integration/autoland/rev/83139f456fcf
part 2 - Clear trackers data when browsing history is cleared r=android-reviewers,harrisono
https://github.com/mozilla-firefox/firefox/commit/2a188b29afa6
https://hg.mozilla.org/integration/autoland/rev/1f22298924db
part 3 - Decouple DeleteBrowsingDataController from the menu fragment lifecycle r=android-reviewers,mcarare

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/eec9088b9ed3
https://hg.mozilla.org/mozilla-central/rev/83139f456fcf
https://hg.mozilla.org/mozilla-central/rev/1f22298924db