2042156 - VPN onboarding sheet is permanently dismissed after navigating back from "Browse with extra protection" link

Status: VERIFIED FIXED

(Firefox for Android :: Privacy, defect)

Description

[Alexandra Martin [:alemartin], FxA/SubPlat/VPN QA]

Attachment: debug_video1.mp4

Prerequisites

• Firefox Nightly is installed with date 8 days in the past and/or cleared of app cache/storage;
• Fx Nightly is opened;
• VPN feature is enabled from Secret Settings;

Steps to reproduce

1. Once the bottom sheet is displayed in HNT, tap on the "Browse with extra protection" link.
2. Go back to HNT.

Expected behavior

• Bottom onboarding sheet is still displayed.

Actual behavior

• Bottom sheet is dismissed and will not appear again.

Device information

• Firefox version: Fx Nightly 153.0a1 (Build #2016162930)
• Android device model: Google Pixel 7a
• Android OS version: Android 16

Any additional information?

• See attached media.

Comment 1

[Alexandra Martin [:alemartin], FxA/SubPlat/VPN QA]

Attachment: screen recording in Google Drive

Comment 2

[:Gela]

Attachment: Bug 2042156 - Do not dismiss the bottom sheet after user taps on Browse with extra protection

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f773a5479d18
https://hg.mozilla.org/integration/autoland/rev/6464c053a442
Do not dismiss the bottom sheet after user taps on Browse with extra protection r=android-reviewers,mavduevskiy

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6464c053a442

Comment 5

[Alexandra Martin [:alemartin], FxA/SubPlat/VPN QA]

Attachment: video3.mp4

Fix verified in Fx Nightly 153.0a1 (Build #2016164946) with Google Pixel 7a (Android 16). Now the bottom onboarding sheet is still displayed after coming back from clicking the "Browse with extra protection" link.