2042200 - Replace addon-page-header buttons with moz-button reusable components

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

This bugzilla issue is tracking converting to moz-button elements the buttons part of the addon page header components, which allows us to simplify the css rules associated to these buttons (and the custom logic wiring the page options button with the related panel list), and prepares this section of the about:addons page to its ongoing restyling part of the project Nova.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 2042200 - Replace button with moz-button in addon-updates-message webcomponent. r?willdurand!

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 2042200 - Change addon-page-header .back-button into ghost moz-button. r?willdurand!

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 2042200 - Change page options button in the addon-page-header webcomponent into a moz-button. r?willdurand!

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Both me and William have discussed about the page options button and we both feel that it feels little bit too subtle as a ghost button, because it blends slightly more into the page because it doesn't have any background color anymore, and so we agreed in the short term to migrate it to a moz-button but to not set type "ghost" on it.

(On the contrary the more options button in the card, which in being converted into a type ghost moz-button as part of 2042204, is a sibling of a toggle button and so we felt that is enough to make it clear enough that it is a control even as a ghost moz-button).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3e481e9d2463
https://hg.mozilla.org/integration/autoland/rev/acfd04d6f533
Replace button with moz-button in addon-updates-message webcomponent. r=willdurand
https://github.com/mozilla-firefox/firefox/commit/232db97a53a3
https://hg.mozilla.org/integration/autoland/rev/f31a7cf9b6bd
Change addon-page-header .back-button into ghost moz-button. r=willdurand
https://github.com/mozilla-firefox/firefox/commit/9b866bb6afea
https://hg.mozilla.org/integration/autoland/rev/73eae7c5f28d
Change page options button in the addon-page-header webcomponent into a moz-button. r=willdurand

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/acfd04d6f533
https://hg.mozilla.org/mozilla-central/rev/f31a7cf9b6bd
https://hg.mozilla.org/mozilla-central/rev/73eae7c5f28d