2042206 - Update styles for payments and addresses edit dialogs

Status: RESOLVED FIXED

(Firefox :: Settings UI, task, P3)

Description

[tanvi.manku]

We need to update the styling of the payments and addresses edit dialogs in about:preferences to align with the Nova spec. This entails:

• Replacing the text fields with moz-input-text=”text”
• Replacing the drop-down fields with moz-select
• Replacing <button> with moz-button

Comment 1

[tanvi.manku]

Attachment: Bug 2042206: Add Nova styling for address and payment edit dialogs. r=mtigley

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/004af3f234f7
https://hg.mozilla.org/integration/autoland/rev/851167946ff7
Add Nova styling for address and payment edit dialogs. r=mtigley,fluent-reviewers,credential-management-reviewers,akulyk,bolsson,hjones

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/651bd135dcca
https://hg.mozilla.org/integration/autoland/rev/0d4c2c45cd5a
Revert "Bug 2042206: Add Nova styling for address and payment edit dialogs. r=mtigley,fluent-reviewers,credential-management-reviewers,akulyk,bolsson,hjones" for causing bc failures @ browser_creditCard_telemetry_manage.js

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_creditCard_telemetry_manage.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/0d4c2c45cd5a6bd99ea883df4dabee207d40edf4

Push with failures

Failures log ->TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/creditCard/browser_creditCard_telemetry_manage.js

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1ac38a438b6b
https://hg.mozilla.org/integration/autoland/rev/4a8cd02c2167
Add Nova styling for address and payment edit dialogs. r=mtigley,fluent-reviewers,credential-management-reviewers,akulyk,bolsson,hjones

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5eef94d01fda
https://hg.mozilla.org/integration/autoland/rev/bdbb9c0be212
Revert "Bug 2042206: Add Nova styling for address and payment edit dialogs. r=mtigley,fluent-reviewers,credential-management-reviewers,akulyk,bolsson,hjones" for causing linting failures.

Comment 7

[Serban Stanca [:SerbanS]]

Reverted this because it was causing linting failures.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/extensions/formautofill/content/editCreditCard.mjs:13:1 | Imported module should be assigned (import/no-unassigned-import)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4146220071d3
https://hg.mozilla.org/integration/autoland/rev/ff3b7f8ef74a
Add Nova styling for address and payment edit dialogs. r=mtigley,fluent-reviewers,credential-management-reviewers,akulyk,bolsson,hjones

Comment 9

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/ff3b7f8ef74a