2042277 - Date/time spinners misaligned with last item selected

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P3)

Description

[Sam Johnson]

Attachment: Screenshot 2026-05-25 at 11.46.41 PM.png

When the last item in a date/time picker spinner is selected, the selected item is slightly too low due to a miscalculation when determining margins.

Comment 1

[Sam Johnson]

Attachment: Bug 2042277 - Fix date/time picker spinner alignment with last item selected. r?#recomp-reviewers

The pre-exisiting margin of the last picker item was ignored when its new margin was calculated, which caused the item to appear misaligned.

Comment 2

[Jonathan Kew [:jfkthame]]

Moving to Toolkit, as this seems more of a front-end issue than a Core Layout bug.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/579faf31e0b4
https://hg.mozilla.org/integration/autoland/rev/fc1c457054d3
Fix date/time picker spinner alignment with last item selected. r=tgiles

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/fc1c457054d3

Comment 5

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:sam, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox153 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Sam Johnson]

Not very important at all, and has been like this ~forever :)