Closed
Bug 2042319
Opened 15 days ago
Closed 7 days ago
Divider placed between "Private browsing" and "Built-in VPN" in Settings menu
Categories
(Firefox for Android :: Privacy, defect)
Tracking
()
VERIFIED
FIXED
153 Branch
| Tracking | Status | |
|---|---|---|
| firefox153 | --- | verified |
People
(Reporter: alemartin, Assigned: Gela)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [fxdroid])
Attachments
(3 files)
Prerequisites
- Have VPN feature enabled;
Steps to reproduce
- Open the Fx Nightly app and tap on the Meatball menu.
- Tap on "Settings".
- Scroll down to the "Privacy and security" section and observe the screen.
Expected behavior
VPN section is displayed according to Figma designs.
Actual behavior
There is a divider between "Private browsing" and "Built-in VPN".
Device information
- Firefox version: Fx Nightly 153.0a1 (Build #2016163039)
- Android device model: Google Pixel 7a
- Android OS version: Android 16
Any additional information?
- not sure if Figma designs are not up to date anymore, since the naming convention for the VPN preference row is now "Built-in VPN" in the app from Figma's "VPN";
Updated•15 days ago
|
Comment 1•15 days ago
|
||
not sure if Figma designs are not up to date anymore, since the naming convention for the VPN preference row is now "Built-in VPN" in the app from Figma's "VPN";
The Figma designs are outdated. It's now called Built-in VPN as far as I know. I see that in desktop code too.
Updated•9 days ago
|
Attachment #9592311 -
Attachment description: WIP: Bug 2042319 - Do not show a divider above Built-in VPN in the settings menu → Bug 2042319 - Do not show a divider above Built-in VPN in the settings menu
Updated•9 days ago
|
Assignee: nobody → gmalekpour
Status: NEW → ASSIGNED
Pushed by mavduevskiy@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/5caeb300d11b
https://hg.mozilla.org/integration/autoland/rev/6e736a95ae12
Do not show a divider above Built-in VPN in the settings menu r=android-reviewers,mavduevskiy
Comment 4•7 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 days ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
| Reporter | ||
Comment 5•6 days ago
|
||
Fix verified in Fx Nightly 153.0a1 (Build #2016164946) with Google Pixel 7a (Android 16). Now there is no divider between "Private browsing" and "Built-in VPN".
| Reporter | ||
Updated•6 days ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•