2042339 - [LNA] Enable LNA Restrictions for Websockets

Status: RESOLVED FIXED

(Core :: DOM: Networking, enhancement, P2)

Description

[Sunil Mayya]

We need to enable LNA restrictions for websockets.
We just to flip the pref network.lna.websocket.enabled

Comment 1

[Sunil Mayya]

[Tracking Requested - why for this release]: Ship LNA restrictions for websockets in Firefox.

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Affects Firefox for Android]: yes
[Suggested wording]:
Firefox's Local Network Access protections now extend to WebSocket connections. Websites that try to open a WebSocket to a device on your local network will ask for your permission first
[Links (documentation, blog post, etc)]:

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox153 (nightly). However, the bug still isn't assigned.

:ghess, could you please find an assignee for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 3

[Sunil Mayya]

[Tracking Requested - why for this release]: Moving this to 154 as we did not land the required change in nightly and we need this to ride through one full nightly cycle.

Comment 4

[Sunil Mayya]

Attachment: Bug 2042339 - [LNA] Enable LNA Restrictions for WebSockets. r?#necko-reviewers

Flip network.lna.websocket.enabled to true so WebSocket connections
follow the normal Local Network Access rules instead of being skipped
in nsHttpTransaction::AllowedToConnectToIpAddressSpace.

Worker WebSocket enforcement relies on the channel LoadInfo carrying a
ClientInfo (Bug 1967266); with that in place the previously disabled
worker WebSocket WPT subtests pass, so re-enable them for dedicated,
shared and service workers. The WebTransport subtests stay disabled
(Bug 2042527).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/db530df9550e
https://hg.mozilla.org/integration/autoland/rev/a6d2a53cca50
[LNA] Enable LNA Restrictions for WebSockets. r=necko-reviewers,valentin

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a6d2a53cca50

Comment 7

[Donal Meehan [:dmeehan]]

Added to the Fx154 nightly release notes, please allow 30 minutes for the site to update. This will carry over to the final Fx154 release notes.