2042379 - ondispose not fired for all frames

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Andreas Farre [:farre]]

Only the navigated frame has its navigation history entries clobbered. Makes navigation-api/per-entry-events/dispose-for-navigation-in-child.html fail

Comment 1

[Andreas Farre [:farre]]

Attachment: Bug 2042379 - Part 1: Make sure to truncate navigation.entries when sesion history changes length. r=#dom-core!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/df39d8a09664
https://hg.mozilla.org/integration/autoland/rev/0e1d7bb8afa3
Make sure to truncate navigation.entries when sesion history changes length. r=jjaschke

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3f1235a56fda
https://hg.mozilla.org/integration/autoland/rev/20dd8f0742f3
Revert "Bug 2042379 - Make sure to truncate navigation.entries when sesion history changes length. r=jjaschke" for causing mochitests failures in browser_purge_shistory.js.

Comment 4

[Serban Stanca [:SerbanS]]

Reverted this because it was causing mochitests failures in browser_purge_shistory.js.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-TIMEOUT | browser/components/sessionstore/test/browser_purge_shistory.js | application timed out after 370.0 seconds with no output

L.E. Also please check this one and this one.

Comment 5

[BMO Github Automation]

Authored by https://github.com/farre
https://github.com/mozilla/enterprise-firefox/commit/df39d8a09664f441fb6ad837005f13d2c374907c
[enterprise-main] Bug 2042379 - Make sure to truncate navigation.entries when sesion history changes length. r=jjaschke

Authored by https://github.com/sstanca-cell
https://github.com/mozilla/enterprise-firefox/commit/3f1235a56fdab14663737cbb143fa96777b4cba6
[enterprise-main] Revert "Bug 2042379 - Make sure to truncate navigation.entries when sesion history changes length. r=jjaschke" for causing mochitests failures in browser_purge_shistory.js.

Comment 6

[Andreas Farre [:farre]]

Filed bug 2042897, fixed bug 2039866.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/36fc8f5360fd
https://hg.mozilla.org/integration/autoland/rev/39dd8f89bfa1
Make sure to truncate navigation.entries when sesion history changes length. r=jjaschke

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ace81424e97d
https://hg.mozilla.org/integration/autoland/rev/38efb73077f4
Revert "Bug 2042379 - Make sure to truncate navigation.entries when sesion history changes length. r=jjaschke" for causing bc failures @Navigation.cpp.

Comment 9

[Andreas Farre [:farre]]

Attachment: Bug 2042379 - Part 2: Disallow non blank about: pages. r=#dom-core!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1147371945a3
https://hg.mozilla.org/integration/autoland/rev/7b3553f0a27f
Part 1: Make sure to truncate navigation.entries when sesion history changes length. r=jjaschke
https://github.com/mozilla-firefox/firefox/commit/05290bd52292
https://hg.mozilla.org/integration/autoland/rev/858a51d75be1
Part 2: Disallow non blank about: pages. r=dom-core,smaug

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/7b3553f0a27f
https://hg.mozilla.org/mozilla-central/rev/858a51d75be1