Closed Bug 2042419 Opened 5 months ago Closed 5 months ago

Update size of close button icons in sidebar panels

Categories

(Firefox :: Sidebar, task)

task

Tracking

()

RESOLVED FIXED
153 Branch
Tracking Status
firefox153 --- fixed

People

(Reporter: kcochrane, Assigned: dr.seed.lu, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-sidebar][outreachy-sidebar-2026])

Attachments

(1 file, 1 external file)

We need to update the size of the close button icons for the new open tabs panel and Tabs from other devices panel in the sidebar to match the size of the close button icons for tabs in the tab strip.

The close button icons on rows in the Open Tabs and Tabs from other
devices panels, and on the panel headers, were rendering larger than
the close buttons on tabs in the tab strip. This patch shrinks them
to match: a 12px glyph inside a 24x24 button box, the same dimensions
the tab strip uses.

  • sidebar-tab-row.css: override --icon-size on the per-row dismiss
    button used by both panels through sidebar-tab-list.
  • sidebar-panel-header.css: override --button-size-icon,
    --button-min-height, and --icon-size on the panel header close
    button. sidebar-panel-header is shared by every sidebar panel, so
    the change applies to all of them and keeps the close icons
    consistent across the revamped sidebar.
Assignee: nobody → dr.seed.lu
Status: NEW → ASSIGNED
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8213555e8c88 https://hg.mozilla.org/integration/autoland/rev/9b89e07e7553 Update size of close button icons in sidebar panels r=kcochrane,desktop-theme-reviewers,fxview-reviewers
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: