Open Bug 2042425 Opened 5 months ago Updated 3 months ago

Fix clippy warnings in toolkit/components/glean/api/src/private/labeled_boolean.rs

Categories

(Developer Infrastructure :: Lint and Formatting, task)

task

Tracking

(Not tracked)

People

(Reporter: Sylvestre, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=rust] )

Filing as a good first bug to learn workflows.

toolkit/components/glean/api/src/private/labeled_boolean.rs
  118:46  warning  this expression creates a reference which is immediately dereferenced by the compiler  clippy::needless_borrow (clippy)
  121:55  warning  this expression creates a reference which is immediately dereferenced by the compiler  clippy::needless_borrow (clippy)

Link to the code:
https://searchfox.org/mozilla-central/source/toolkit/components/glean/api/src/private/labeled_boolean.rs#118

To run the linter:

./mach lint -W -l clippy toolkit/components/glean/api/src/private/labeled_boolean.rs

As the change is trivial, it is just to learn how to contribute to Firefox.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Whiteboard: [lang=rust]

./mach lint -W -l clippy toolkit/components/glean/api/src/private/labeled_boolean.rs
✖ 0 problems (0 errors, 0 warnings, 0 fixed)

Flags: needinfo?(sledru)
You need to log in before you can comment on or make changes to this bug.