Closed Bug 2042435 Opened 5 months ago Closed 3 months ago

Fix ruff warnings in build/clang-plugin/ThirdPartyPaths.py

Categories

(Developer Infrastructure :: Lint and Formatting, defect)

defect

Tracking

(firefox155 fixed)

RESOLVED FIXED
155 Branch
Tracking Status
firefox155 --- fixed

People

(Reporter: Sylvestre, Assigned: pedram.yekta12)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=python])

Attachments

(1 external file)

Filing as a good first bug to learn workflows.

build/clang-plugin/ThirdPartyPaths.py
  20:9   warning  `for` loop variable `line` overwritten by assignment target  PLW2901 (ruff)
  22:13  warning  `for` loop variable `line` overwritten by assignment target  PLW2901 (ruff)
  27:9   warning  Use format specifiers instead of percent format              UP031 (ruff)

Link to the code:
https://searchfox.org/mozilla-central/source/build/clang-plugin/ThirdPartyPaths.py#20

To run the linter:

./mach lint -W -l ruff build/clang-plugin/ThirdPartyPaths.py

As the change is trivial, it is just to learn how to contribute to Firefox.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Blocks: ruff

(cherry picked from commit a52dbe9fb9436381a255e7065cd58c6989b10037)

Assignee: nobody → pedram.yekta12
Status: NEW → ASSIGNED
Attachment #9595399 - Attachment description: Bug 2042435 - Fix Ruff warnings in ThirdPartyPaths.py. r=sylvestre → Bug 2042435 - Fix Ruff warnings in ThirdPartyPaths.py. r=sylvestre

There is an r+ patch which didn't land and no activity in this bug for 1 week.
:pedram.yekta12, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(sledru)
Flags: needinfo?(pedram.yekta12)
Flags: needinfo?(sledru)
Flags: needinfo?(pedram.yekta12)
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: