Closed Bug 2042436 Opened 5 months ago Closed 5 months ago

Fix ruff warnings in build/valgrind/mach_commands.py

Categories

(Developer Infrastructure :: Lint and Formatting, defect)

defect

Tracking

(firefox154 fixed)

RESOLVED FIXED
154 Branch
Tracking Status
firefox154 --- fixed

People

(Reporter: Sylvestre, Assigned: pedram.yekta12)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=python])

Attachments

(1 external file)

Filing as a good first bug to learn workflows.


build/valgrind/mach_commands.py
   75:23  warning  Use format specifiers instead of percent format           UP031 (ruff)
   79:17  warning  `for` loop variable `v` overwritten by assignment target  PLW2901 (ruff)
  192:25  warning  Use format specifiers instead of percent format           UP031 (ruff)

Link to the code:
https://searchfox.org/mozilla-central/source/build/valgrind/mach_commands.py#75

To run the linter:

./mach lint -W -l ruff build/valgrind/mach_commands.py

As the change is trivial, it is just to learn how to contribute to Firefox.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Blocks: ruff
Assignee: nobody → pedram.yekta12
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: