2042678 - [HDR/Windows] Change allowlist to blocklist and rely on detection of unsupported conversions

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, task, P2)

Description

[Ashley Hale [:ahale]]

The allowlist approach for limiting supported GPUs to AMD and NVIDIA has not been very reliable, we should just change it to a blocklist with an initially empty list, so that we can still use it as a kill switch as needed.

The detection of supported VideoProcvessorBlt conversions is much better so that should be our primary approach.

Comment 1

[Ashley Hale [:ahale]]

Attachment: Bug 2042678 - Change VIDEO_HDR allowlist to blocklist with no entries r?#gfx-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/58e08926f91b
https://hg.mozilla.org/integration/autoland/rev/34eff4edaa66
Change VIDEO_HDR allowlist to blocklist with no entries r=gfx-reviewers,bradwerth

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/34eff4edaa66

Comment 4

[Ashley Hale [:ahale]]

Attachment: Bug 2042678 - Change VIDEO_HDR allowlist to blocklist with no entries

Original Revision: https://phabricator.services.mozilla.com/D302864

Comment 5

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: HDR video for Windows in Fx152 needs better detection of limitations of Intel graphics on hybrid laptops (Intel+NVIDIA typically), these patches improve that to be more robust in all configurations rather than checking primary GPU model.
• Code covered by automated testing?: no
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: This will be foxfooded and manually tested in general.

Basic test instructions:

• setup: enable HDR mode in Windows - Settings - Display - HDR. Don't bother testing if that can not be enabled.
• play any HDR YouTube video on an Intel iGPU based system, a particularly good test is https://www.youtube.com/watch?v=vP-ctJUQBws - verify the settings gear in the bottom right of the video player does not say HDR in small white on red text over the gear, HD is fine, 4K is fine, but not HDR.
• play any HDR YouTube video on an AMD or NVIDIA GPU system, such as the one linked above, and verify the settings gear says HDR and the video should look bright but reasonable, there is a very bright white scene at 0:05 which should be brighter than the player controls and mouse cursor.
• Risk associated with taking this patch: low
• Explanation of risk level: Low. Our allowlist was not robust on some systems, this reduces risk by testing the actual features of the driver rather than primary GPU.
• String changes made/needed?: N/A
• Is Android affected?: no

Comment 6

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/15b47673bb8d
https://hg.mozilla.org/releases/mozilla-beta/rev/6ba3c898cb49