2042852 - (Android) - FxA Active auth provider handles updateEntitlement diffrent

Status: RESOLVED FIXED

(Firefox :: IP Protection, defect)

Description

[Sebastian Streich [:sstreich]]

The Old-FxA auth proivder had some side effects, that the activate one does not provide.
-> Usage polling
-> Sending change events when the entitlement was updated

Comment 1

[Sebastian Streich [:sstreich]]

Attachment: Bug 2042852 - Fix behavior diffrence between FxA Auth proiders r?#ip-protection-reviewers

Fn the other FxA auth provider scheudles a usage update when the entitlement is updated. Also it notifies the state change.

The Activate Provider doesn't do that, yet was planned to be a drop in replacement. So for now it should act the same

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8b61fac11f23
https://hg.mozilla.org/integration/autoland/rev/983392a6322b
Fix behavior diffrence between FxA Auth proiders r=ip-protection-reviewers,baku

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bb79a824d0f6
https://hg.mozilla.org/integration/autoland/rev/9c9757d9b120
Revert "Bug 2042852 - Fix behavior diffrence between FxA Auth proiders r=ip-protection-reviewers,baku" for causing wpt failures cache-put.https.any.worker.html

Comment 4

[Silaghi Andreea]

Backed out for causing wpt and bc failures cache-put.https.any.worker.html
Backout Link
Push with failures
Failure Log
bc
Failure line TEST-UNEXPECTED-FAIL | /service-workers/cache-storage/cache-put.https.any.html | Cache.put with opaque-filtered HTTP 206 response - promise_test: Unhandled rejection with value: object "TypeError: NetworkError when attempting to fetch resource."

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4b26acdf0de8
https://hg.mozilla.org/integration/autoland/rev/c2e604a2ed2c
Fix behavior diffrence between FxA Auth proiders r=ip-protection-reviewers,baku

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bb343d5b9453
https://hg.mozilla.org/integration/autoland/rev/16768e80cae3
Revert "Bug 2042852 - Fix behavior diffrence between FxA Auth proiders r=ip-protection-reviewers,baku" for causing bc failures at browser_ipprotection_infobar.js

Comment 7

[rperta]

Backed out for causing bc failures at browser_ipprotection_infobar.js
Backout link
Push with failures
Failure log(s)

Comment 8

[Sebastian Streich [:sstreich]]

Third time's the charm. Should be fixed now, sorry!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d887d3259726
https://hg.mozilla.org/integration/autoland/rev/41b075605ec1
Fix behavior diffrence between FxA Auth proiders r=ip-protection-reviewers,baku

Comment 10

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/41b075605ec1