2042893 - Middle click paste into address bar doesn't replace existing content anymore

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Manuel Bucher [:manuel] {{ FYI: OOO Jul 30 - Aug 16 }}]

STR:

1. open a website (e.g. https://wikipedia.org)
2. select some text to put into secondary clipboard (likely linux-only)
3. middle click on address bar

Expected result: content from address bar is replaced with selected content
Got result: selected content is pasted at position where the middle click happened

Regression bug found via mozregression (larger regression window than usual, but picked most likely bug: https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=e41f1f9aa58a7d4c0c79bc3c9e4a234136e83dc7&tochange=602084a80545c3aa2879ec54585f298966b00839)

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2030983

:mbeier, since you are the author of the regressor, bug 2030983, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Moritz Beier [:mbeier]]

Attachment: Bug 2042893 - Make sure middle click paste into address bar replaces existing content. r?#urlbar-reviewers

This happened because converting urlbar-input-container from a xul hbox to an html div caused "click" events to not fire because "click" only fires for the primary mouse button in HTML.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/64ac51f872b9
https://hg.mozilla.org/integration/autoland/rev/2c047828543b
Make sure middle click paste into address bar replaces existing content. r=urlbar-reviewers,jteow

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2c047828543b

Comment 5

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:mbeier, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox152 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2026-05-27 Firefox Nightly build on Ubuntu 22, using the STR from Comment 0.

Verified as fixed on Firefox Nightly 153.0a1 on Ubuntu 22.

Comment 7

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Users have to manually clear the urlbar before middle click pasting on Linux
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: See https://bugzilla.mozilla.org/show_bug.cgi?id=2042893#c0
• Risk associated with taking this patch: low
• Explanation of risk level: Very small change
• String changes made/needed?: no
• Is Android affected?: no

Comment 8

[Moritz Beier [:mbeier]]

Attachment: Bug 2042893 - Make sure middle click paste into address bar replaces existing content.

This happened because converting urlbar-input-container from a xul hbox to an html div caused "click" events to not fire because "click" only fires for the primary mouse button in HTML.

Original Revision: https://phabricator.services.mozilla.com/D303007

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/2f7b9aeec3ed
https://hg.mozilla.org/releases/mozilla-beta/rev/5e7c4237cbe1

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Verified as fixed on Firefox 152.0b10 on Ubuntu 22.