2042894 - Show AppErrorBoundary when inspector fails rendering the markup view

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement)

Description

[Alexandre Poirot [:ochameau]]

Bug 2042101 is a good example of an inspector crash, leading to a blank markup view with no actionable feedback.

We should be rendering the AppErrorBoundary when we know the inspector crashed and won't be rendering any markup view.
It would help us see all the proper stacktraces and also help the user know devtools crashed and have a call for action.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 2042894 - [devtools] Show AppErrorBoundary when the inspector fails rendering the markup view. r=#devtools

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e001fd3251c0
https://hg.mozilla.org/integration/autoland/rev/29c24a611336
[devtools] Show AppErrorBoundary when the inspector fails rendering the markup view. r=devtools-reviewers,jdescottes

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/811834ef3254
https://hg.mozilla.org/integration/autoland/rev/1248c10d4ade
Revert "Bug 2042894 - [devtools] Show AppErrorBoundary when the inspector fails rendering the markup view. r=devtools-reviewers,jdescottes" for causing failures at browser_toolbox_backward_forward_navigation.js.

Comment 4

[Atila Butkovits]

Backed out for causing failures at browser_toolbox_backward_forward_navigation.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/1248c10d4ade

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=29c24a6113367f23083110f9a885dc149eaf7e95&selectedTaskRun=Gi_XIL4PTee5_KIHCMlACQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=570052510&repo=autoland&task=Gi_XIL4PTee5_KIHCMlACQ.0&lineNumber=6622

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b33f115eb072
https://hg.mozilla.org/integration/autoland/rev/6cc0efe07b85
[devtools] Show AppErrorBoundary when the inspector fails rendering the markup view. r=devtools-reviewers,jdescottes

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/6cc0efe07b85