Closed Bug 2042921 Opened 5 months ago Closed 5 months ago

Add keyboard shortcut for opening the new Open Tabs panel of the sidebar

Categories

(Firefox :: Sidebar, task, P2)

task

Tracking

()

RESOLVED FIXED
153 Branch
Tracking Status
firefox153 --- fixed

People

(Reporter: kcochrane, Assigned: dr.seed.lu, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-sidebar][outreachy-sidebar-2026])

Attachments

(1 file, 1 external file)

We need to add a new keyboard shortcut for opening the new Open Tabs panel added in bug 2039294. I've spoken with Ania and we've decided to go with Ctrl + Shift + L for the new shortcut. We should also document this new shortcut in about:keyboard

Severity: -- → S3
Priority: -- → P2

Adds Ctrl+Shift+L (Cmd+Shift+L on Mac) to open the Open Tabs sidebar
panel.

The wiring follows the same pattern Bookmarks (Ctrl+B) and History
(Ctrl+H) use:a <key> element in browser-sets defines the key, the
FTL string gives it the letter, a case in browser-sets.js routes the
key's command to SidebarController.toggle, and keyId on the sidebar
registration ties the menubar menuitem to the key so the shortcut
shows up under View > Sidebars and in about:keyboard.

  • browser-sets.inc.xhtml: new <key id="viewOpenTabsSidebarKb"> with
    modifiers="accel,shift".

  • browserSets.ftl: open-tabs-sidebar-shortcut with .key = L.

  • browser-sets.js: case for viewOpenTabsSidebarKb calling
    SidebarController.toggle("viewOpenTabsSidebar").

  • browser-sidebar.js: keyId in the Open Tabs sidebar registration so
    the menubar menuitem gets the key= attribute.

  • browser_opentabs_sidebar.js: test that the shortcut opens the panel
    and a second press closes it.

Assignee: nobody → dr.seed.lu
Status: NEW → ASSIGNED
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e32dab7db21f https://hg.mozilla.org/integration/autoland/rev/5e84846d5620 Add keyboard shortcut for opening the new Open Tabs panel of the sidebar r=kcochrane,nsharpley,fluent-reviewers,bolsson
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Regressions: 2045206
See Also: → 2045243
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: