Closed Bug 2042953 Opened 3 months ago Closed 2 months ago

[Google Lens] Add QR code scan from image upload to Google Lens flow

Categories

(Firefox for Android :: Search, task)

Product:
Firefox for Android
Component:
Search
Platform:
All
Android
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
153 Branch
Tracking Flags:
Tracking Status
firefox153 --- fixed

People

(Reporter: harrisono, Assigned: harrisono)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][group3])

Attachments

(2 files)

Bug 2042953 - Part 1: Add still-image bitmap decoding to QrAnalyzer
48 bytes, text/x-phabricator-request
Details | Review
Bug 2042953 - Part 2: Scan QR codes from gallery images in Lens camera QR mode
48 bytes, text/x-phabricator-request
Details | Review

Users should be able to scan QR codes from uploaded images as well as the live camera view. Add this to the combined Google Lens/QR Code flow.

Assignee: nobody → hoglesby
Status: NEW → ASSIGNED
Whiteboard: [fxdroid][group3]
Attachment #9591123 - Attachment description: WIP: Bug 2042953 - Part 1: Add still-image bitmap decoding to QrAnalyzer → Bug 2042953 - Part 1: Add still-image bitmap decoding to QrAnalyzer
Attachment #9591124 - Attachment description: WIP: Bug 2042953 - Part 2: Scan QR codes from gallery images in Lens camera QR mode → Bug 2042953 - Part 2: Scan QR codes from gallery images in Lens camera QR mode
Pushed by hoglesby@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ab376f9f73b9 https://hg.mozilla.org/integration/autoland/rev/6edf1e3842a9 Part 1: Add still-image bitmap decoding to QrAnalyzer r=android-reviewers,petru https://github.com/mozilla-firefox/firefox/commit/f85954d545ad https://hg.mozilla.org/integration/autoland/rev/d885b3f735ec Part 2: Scan QR codes from gallery images in Lens camera QR mode r=android-reviewers,petru
Pushed by rperta@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f4603049e2e6 https://hg.mozilla.org/integration/autoland/rev/979b949e2f68 Revert "Bug 2042953 - Part 2: Scan QR codes from gallery images in Lens camera QR mode r=android-reviewers,petru" for causing fenix failures

Backed out for causing fenix failures
Backout link
Push with failures
Failure log(s)

Flags: needinfo?(hoglesby)
Pushed by hoglesby@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f463ba0503c3 https://hg.mozilla.org/integration/autoland/rev/d41b754bcc78 Part 1: Add still-image bitmap decoding to QrAnalyzer r=android-reviewers,petru https://github.com/mozilla-firefox/firefox/commit/55d7d786a846 https://hg.mozilla.org/integration/autoland/rev/5c4fabb19d1b Part 2: Scan QR codes from gallery images in Lens camera QR mode r=android-reviewers,petru

fixed the test failures and re-landed the patches

Flags: needinfo?(hoglesby)

https://hg.mozilla.org/mozilla-central/rev/d41b754bcc78
https://hg.mozilla.org/mozilla-central/rev/5c4fabb19d1b

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox153: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: