2042999 - Enable non-legacy line-clamp to work without special values

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[David Shin[:dshin]]

... Unlike -webkit-line-clamp, this should not depend on display: -webkit-box | -webkit-inline-box and -webkit-box-orient.
For the purposes of incremental work, we're going to ignore custom/no ellipsis values here.

Comment 1

[David Shin[:dshin]]

Additional note, this part also needs to be rejiggered a bit here.
Namely, line-clamp container establishes an independent block formatting context. We need to make sure the above part of the code activates for non-legacy line-clamp, which likely involves avoiding this part if not legacy.

Comment 2

[Seva Alipov]

Attachment: Bug 2042999: Enable non-legacy line-clamp to work without special values. r=#style,#layout

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4f7b9ecf4798
https://hg.mozilla.org/integration/autoland/rev/b6a49af97329
Enable non-legacy line-clamp to work without special values. r=firefox-style-system-reviewers,layout-reviewers,dshin,AlaskanEmily

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f82f166dffa5
https://hg.mozilla.org/integration/autoland/rev/d14517bb7466
Revert "Bug 2042999: Enable non-legacy line-clamp to work without special values. r=firefox-style-system-reviewers,layout-reviewers,dshin,AlaskanEmily" for causing wr failures @ line-clamp-026.html

Comment 5

[pstanciu]

Backed out for causing wr failures @ line-clamp-026.html

• https://hg.mozilla.org/integration/autoland/rev/d14517bb7466c633d81963464f21a92793cf5f40
• Push with failures
• Failure Log

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/61384 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 8

[Seva Alipov]

The test was failing on some platforms due to fuzz with text rendering. I have added a tolerance to this test.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0e084adab846
https://hg.mozilla.org/integration/autoland/rev/fa790382d48a
Enable non-legacy line-clamp to work without special values. r=firefox-style-system-reviewers,layout-reviewers,dshin,AlaskanEmily

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/fa790382d48a

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot