2043002 - Implement the automatic, container size based line clamping for `line-clamp` longhand

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[David Shin[:dshin]]

line-clamp: auto;
line-clamp: ellipsis;

etc.

Number of lines clamped depend on the block size of the container.

Should also be noted that line-clamp: 3 auto; is possible, and basically fits min(# lines specified, # lines fitting in block size)

Comment 1

[Seva Alipov]

Attachment: WIP: - Bug 2043002: Implement the automatic, container size based line clamping for css line-clamp. r=#layout

Comment 2

[Seva Alipov]

Attachment: WIP: - Bug 2043002: Implement the automatic, container size based line clamping for css line-clamp. r=#layout

Comment 3

[Seva Alipov]

Attachment: Bug 2043002: Implement the automatic, container size based line clamping for css line-clamp. r=#layout

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/51cdaf975231
https://hg.mozilla.org/integration/autoland/rev/26e37107acc7
Implement the automatic, container size based line clamping for css line-clamp. r=layout-reviewers,dshin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4bce60375c95
https://hg.mozilla.org/integration/autoland/rev/d25060c40d55
Revert "Bug 2043002: Implement the automatic, container size based line clamping for css line-clamp. r=layout-reviewers,dshin" for causing wr tests failures at line-clamp

Comment 6

[Silaghi Andreea]

Backed out for causing wr tests failures at line-clamp
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-PASS | /css/css-overflow/line-clamp/line-clamp-auto-041.html | Testing http://web-platform.test:8000/css/css-overflow/line-clamp/line-clamp-auto-041.html == http://web-platform.test:8000/css/css-overflow/line-clamp/reference/line-clamp-auto-041-ref.html

Comment 7

[Seva Alipov]

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=2069118

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c5b375897eb7
https://hg.mozilla.org/integration/autoland/rev/ff81e32338c5
Implement the automatic, container size based line clamping for css line-clamp. r=layout-reviewers,dshin

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/31ff9ec4b3dd
https://hg.mozilla.org/integration/autoland/rev/df6015b6cfa2
Revert "Bug 2043002: Implement the automatic, container size based line clamping for css line-clamp. r=layout-reviewers,dshin for causing wpt failures @ TEST-UNEXPECTED-FAIL | /css/css-overflow/line-clamp/line-clamp-balance-005.html

Comment 10

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failures @ TEST-UNEXPECTED-FAIL | /css/css-overflow/line-clamp/line-clamp-balance-005.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/df6015b6cfa2d970c04e7b279d17657972550051

Push with failures

Failures log ->TEST-UNEXPECTED-FAIL | /css/css-overflow/line-clamp/line-clamp-balance-005.html | Testing http://web-platform.test:8000/css/css-overflow/line-clamp/line-clamp-balance-005.html

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/56b246655ff3
https://hg.mozilla.org/integration/autoland/rev/8543d929ffe6
Implement the automatic, container size based line clamping for css line-clamp. r=layout-reviewers,dshin

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/62467 for changes under testing/web-platform/tests

Comment 13

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/8543d929ffe6

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot