Closed Bug 2043007 Opened 5 months ago Closed 1 month ago

Ensure that we don’t skip painting of abspos elements whose placeholder got line-clamped out

Categories

(Core :: CSS Parsing and Computation, enhancement)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement
Points:
8

Tracking

()

Status:
RESOLVED FIXED
Milestone:
159 Branch
Tracking Flags:
Tracking Status
firefox159 --- fixed

People

(Reporter: dshin, Assigned: kyoety)

References

(Blocks 1 open bug)

Details

(Whiteboard: css-line-clamp, [wptsync upstream])

Attachments

(1 external file)

This should prevent us from running back into bug 1934547.

Points: --- → 8
Whiteboard: css-line-clamp
Assignee: nobody → kye
Status: NEW → ASSIGNED
Attachment #9641229 - Attachment description: Bug 2043007 - Continue display-list traversal after line clamping for visible out-of-flow descendants. r=dshin,alaskanemily → WIP: Bug 2043007 - Continue display-list traversal after line clamping for visible out-of-flow descendants. r=dshin,alaskanemily
Attachment #9641229 - Attachment description: WIP: Bug 2043007 - Continue display-list traversal after line clamping for visible out-of-flow descendants. r=dshin,alaskanemily → Bug 2043007 - Continue display-list traversal after line clamping for visible out-of-flow descendants. r=dshin,alaskanemily
Pushed by kye@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/48a357a3441b https://hg.mozilla.org/integration/autoland/rev/1d2868a0480c Continue display-list traversal after line clamping for visible out-of-flow descendants. r=dshin,layout-reviewers
Pushed by asilaghi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/23cd63d8cab2 https://hg.mozilla.org/integration/autoland/rev/b713375861ba Revert "Bug 2043007 - Continue display-list traversal after line clamping for visible out-of-flow descendants. r=dshin,layout-reviewers" for causing web platform tests failures at line-clamp-auto-025.html

Backed out for causing web platform tests failures at line-clamp-auto-025.html
Backout Link
Push with failures
Failure Log
Failure Log TVw
Failure line TEST-UNEXPECTED-FAIL | /css/css-overflow/line-clamp/line-clamp-with-abspos-025.html | Testing http://web-platform.test:8000/css/css-overflow/line-clamp/line-clamp-with-abspos-025.html == http://web-platform.test:8000/css/css-overflow/line-clamp/reference/line-clamp-with-abspos-005-ref.html

Flags: needinfo?(kye)

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/63325 for changes under testing/web-platform/tests

Whiteboard: css-line-clamp → css-line-clamp, [wptsync upstream]

Upstream PR was closed without merging

Pushed by kye@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/9e4be729605c https://hg.mozilla.org/integration/autoland/rev/9cba50921b6b Continue display-list traversal after line clamping for visible out-of-flow descendants. r=dshin,layout-reviewers
Flags: needinfo?(kye)

https://hg.mozilla.org/mozilla-central/rev/9cba50921b6b

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox159: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 159 Branch

Upstream PR merged by moz-wptsync-bot

Regressions: 2079858
QA Whiteboard: [qa-triage-done-c160/b159]
No longer regressions: 2079858
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: