Closed Bug 2043065 Opened 17 days ago Closed 2 days ago

[wpt-sync] Sync PR 60200 - font: Properly handle when shaping produces no glyphs

Categories

(Core :: Layout: Text and Fonts, task, P4)

Product:
Core
Component:
Layout: Text and Fonts
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
153 Branch
Tracking Flags:
Tracking Status
firefox153 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 60200 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/60200
Details from upstream follow.

Martin Robinson <mrobinson@igalia.com> wrote:

font: Properly handle when shaping produces no glyphs

When shaping produces no glyphs, which can happen when a zero-width
space is shaped for a font that has no space or zero-width space glyph,
just return an empty ShapedText instead of trying to process any
glyphs. This prevents logic issues due to the rest of the code assuming
there are glyphs.

Testing: This change adds a new WPT crash test.
Fixes: #<!-- nolink -->45174.

Reviewed in servo/servo#45176

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 46 tests

Status Summary

Firefox

PASS: 1[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, GitHub] 34[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 12

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e0e3f9f6eb4f https://hg.mozilla.org/integration/autoland/rev/c9ee52666c22 [wpt PR 60200] - font: Properly handle when shaping produces no glyphs, a=testonly

https://hg.mozilla.org/mozilla-central/rev/c9ee52666c22

Status: NEW → RESOLVED
Closed: 2 days ago
status-firefox153: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
You need to log in before you can comment on or make changes to this bug.