204307 - fix nspr stubs MingW hacks

Status: RESOLVED FIXED

(NSS :: Build, defect, P3)

Description

[Jonathan Wilson]

Basicly, the nspr stubs dont work on MingW builds and whats there now is labled
a "hack" and should be fixed properly.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

I can't seem to find a file called nsprstubs.c anywhere in my tree.  What's the
path to the file you're speaking of?

Comment 2

[Jonathan Wilson]

ok, security/nss/lib/ckfw/nsprstub.c &
security/nss/lib/fortcrypt/swfort/pkcs11/stub.c are the 2 files in question.

Comment 3

[timeless]

swfort is dead

so all that's left is:
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/security/nss/lib/ckfw/nsprstub.c

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

mingw is not a platform that is actively supported by any of the NSS developers.
This bug report just says it "dont work", and supplies no details whatsoever.
If the reporter would care to provide the necessary details, and perhaps a 
patch, we'll consider it.  Otherwise, this bug will continue to sit in purgatory.

Comment 5

[timeless]

i'm pretty sure the reference is to:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/nss/lib/ckfw/nsprstub.c&rev=1.6&mark=290-292#288

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

Is the problem described in the URL cited above simply another manifestation 
of the problem in bug 337887?  

Does the solution that was committed for bug 337887 also solve the problem
described in that comment?

Now that the fix for bug 337887 has been committed, it might be interesting to 
see if the "hack" (nsprstub.c rev 1.4) can be backed out and mingw still works.
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/security/nss/lib/ckfw&command=DIFF_FRAMESET&file=nsprstub.c&rev2=1.4&rev1=1.3

Comment 7

[cls]

Moot point.  nsprstubs.c hasn't been used since bug 302416 landed.  It probably should have been removed at the same time.

Comment 8

[Wan-Teh Chang]

Right.  This bug is now obsolete because nsprstub.c is not
being used.  I just removed it from CVS (see bug 302416
comment 39).