2043104 - Fenix doesn't need the "session scope" when signing in.

Status: RESOLVED FIXED

(Firefox for Android :: Accounts and Sync, enhancement)

Description

[Mark Hammond [:markh] [:mhammond]]

We request the session scope so that Fenix can obtain a session token given just the auth code. However, in the last few years we also arranged for it to get a session token via the webchannel, which we did to ensure the browser and accounts.firefox.com in that browser had the same session.

The end result is now that we get a new session token which we simply discard. Everything continues to work fine if we just don't request that scope. We'd need it if we ever wanted to support non-webchannel based oauth flows, but that seems unlikely.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 2043104 - don't ask for the session scope when signing in. r?jonalmeida

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 1 week.
:markh, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Jonathan Almeida [:jonalmeida]]

Leaving it to Mark to land when they are back from PTO.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a9b678c24340
https://hg.mozilla.org/integration/autoland/rev/1ff8cb364634
don't ask for the session scope when signing in. r=jonalmeida,android-reviewers

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1ff8cb364634