2043115 - Wikipedia: CTRL+Click by username in site notification leads to /wiki/Null

Status: RESOLVED FIXED

(Firefox :: Menus, defect, P1)

Description

[Alexander Gavrilov [:dartraiden]]

Attachment: mstsc_M5MqwKKm0E.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:151.0) Gecko/20100101 Firefox/151.0

Steps to reproduce:

• Got some notification on Wikipedia (for example, someone thanks me for editing)
• CTRL+Click by author name or page name (marked red on screenshot)

Actual results:

wikipedia.org/wiki/Null is opened in a new tab

Expected results:

The corresponding page opens in a new tab

Comment 1

[Alexander Gavrilov [:dartraiden]]

Broken as result of https://bugzilla.mozilla.org/show_bug.cgi?id=2027969

Comment 2

[Alexander Gavrilov [:dartraiden]]

Discussion on Phabricator
https://phabricator.wikimedia.org/T427053

Comment 3

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Alerts Service' component, but is not confident enough to move the bug to that component.

Comment 4

[Alexander Gavrilov [:dartraiden]]

moz-regression
Differential Revision: https://phabricator.services.mozilla.com/D291163

Comment 5

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:Mardak, could you have a look please?

For more information, please visit BugBot documentation.

Comment 6

[:Gijs (he/him)]

Can you provide a testcase that reproduces the problem (either link to public webpage that doesn't require further actions, or attaching an HTML page here)?

I have a mostly inactive wikipedia account and I appear to have no notifications, and don't understand how to create some (seems to depend on other users' actions?). Using the markup linked in this comment, to create a data url like so:

data:text/html,<a%20class="oo-ui-widget%20oo-ui-widget-enabled%20mw-echo-ui-notificationItemWidget"%20href="https://de.wikipedia.org/w/index.php?title=Irene_Koki_Mutungi&amp;oldid=prev&amp;diff=267116898&amp;markasread=69860213&amp;markasreadwiki=dewiki">%20...%20<a%20class="oo-ui-widget%20oo-ui-widget-enabled%20oo-ui-labelElement%20oo-ui-optionWidget%20oo-ui-buttonElement%20oo-ui-buttonElement-frameless%20oo-ui-buttonElement-size-medium%20oo-ui-iconElement%20oo-ui-buttonOptionWidget%20mw-echo-ui-menuItemWidget%20mw-echo-ui-menuItemWidget-prioritized"%20aria-selected="false"%20tabindex="-1"%20role="option"%20href="https://de.wikipedia.org/wiki/Benutzerin:Tetraeder"%20title="">...%20</a>%20<a%20class="oo-ui-widget%20oo-ui-widget-enabled%20oo-ui-labelElement%20oo-ui-optionWidget%20oo-ui-buttonElement%20oo-ui-buttonElement-frameless%20oo-ui-buttonElement-size-medium%20oo-ui-iconElement%20oo-ui-buttonOptionWidget%20mw-echo-ui-menuItemWidget%20mw-echo-ui-menuItemWidget-prioritized"%20aria-selected="false"%20tabindex="-1"%20role="option"%20href="https://de.wikipedia.org/wiki/Irene_Koki_Mutungi"%20title="Irene%20Koki%20Mutungi"><a%20class="oo-ui-buttonElement-button"%20role="button">...</a>%20...%20</a>

Does not reproduce the problem for me. (Tested on Firefox 154 beta on Windows)

Without a testcase it's difficult to know what is going on and to be confident any changes would actually fix the issue.

Comment 7

[Alexander Gavrilov [:dartraiden]]

Enable or disable 2FA in Wikipedia
https://en.wikipedia.org/wiki/Special:AccountSecurity

The system will immediately generate a notification

Ctrl+Click on the "Help" link in this notification

Comment 8

[BugBot [:suhaib / :marco]]

:fwang, since you are the author of the regressor, bug 2027969, could you take a look?

For more information, please visit BugBot documentation.

Comment 9

[:Gijs (he/him)]

Heading out on a break, will try to get to this when I get back if nobody else gets there first.

Comment 10

[Felix Pahl]

Attachment: test case

a standalone HTML file that uses JavaScript to create nested <a> elements as in the Wikipedia notifications

Comment 11

[:Gijs (he/him)]

Thanks very much for the standalone testcase, that's very helpful.

Workaround is using the context menu, which appears to work correctly. In terms of severity, I'm dithering a bit between S2 and S3 here but I suppose in practice it doesn't matter as long as we fix this soon. Hoping to dig more tonight or tomorrow (digging out of post-vacation backlog).

I still need to actually debug but let's get some tracking flags set.

Comment 12

[:Gijs (he/him)]

Attachment: Bug 2043115 - fix modifier/middle clicks on nested links without an href attribute, r?Mossop

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/61fae682408e
https://hg.mozilla.org/integration/autoland/rev/d1199edf34b3
fix modifier/middle clicks on nested links without an href attribute, r=mossop

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/30d71d4c45a9
https://hg.mozilla.org/integration/autoland/rev/9730adb51ba0
Revert "Bug 2043115 - fix modifier/middle clicks on nested links without an href attribute, r=mossop" for causing failures at browser_trust_panel.js.

Comment 15

[Atila Butkovits]

Backed out for causing failures at browser_trust_panel.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/9730adb51ba0

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d1199edf34b3f319724d9b038a6db21382711f38&selectedTaskRun=U60gGRaXT62reKxEEQeDYg.0

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=589620568&repo=autoland&task=U60gGRaXT62reKxEEQeDYg.0&lineNumber=13258
https://treeherder.mozilla.org/logviewer?job_id=589614008&repo=autoland&task=fTAI8xV9ST-xxH2q0a9jcQ.0&lineNumber=6868

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dddac0f84bf4
https://hg.mozilla.org/integration/autoland/rev/57e82a9f17d9
fix modifier/middle clicks on nested links without an href attribute, r=mossop

Comment 17

[Kelly Cochrane [:kcochrane]]

Attachment: Revert "Bug 2043115 - fix modifier/middle clicks on nested links without an href attribute, r=mossop" for causing failures at browser_trust_panel.js.

This reverts commit 61fae682408e60ec42ea27eec26d536f6372fce0.

Comment 18

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/57e82a9f17d9