2043210 - VPN onboarding bottom sheet clips primary buttons in landscape mode on small viewports

Status: VERIFIED FIXED

(Firefox for Android :: Privacy, defect)

Description

[Alexandra Martin [:alemartin], FxA/SubPlat/VPN QA]

Attachment: Google Pixel 7a onboarding sheet in landscape mode

Prerequisites

• Firefox Nightly is installed on a small screen device.
• The "Try Firefox's built-in VPN" onboarding bottom sheet is triggered.

Steps to reproduce

1. View the active VPN onboarding bottom sheet on a small screen device in landscape mode.
2. Attempt to scroll down within the bottom sheet container to reveal the call-to-action (CTA) buttons.
3. Observe the swipe gesture interaction with the sheet layout.

Expected behavior

• Primary action buttons are visible within the immediate viewport without requiring scrolling.

Actual behavior

• The layout forces the primary action buttons ("Get started" and "Not now") to be cut, requiring a scroll gesture that can cause accidental dismissals.

Device information

Firefox version: Fx Nightly 153.0a1 (Build #2016163143)
Android device model: Google Pixel 7a
Android OS version: Android 16

Any additional information?

• Google Pixel 7a has a screen size of 6.1 inches, which only blocks partially the "Not now" and "Get started" buttons (and can be actionable, if handled carefully), but on a smaller screen size device (e.g. Sony Xperia XZ with 5.2 inches) the buttons are not showing at all and scroll actions are needed to reveal the buttons which can cause accidental dismissal of the Onboarding sheet;

Comment 1

[Alexandra Martin [:alemartin], FxA/SubPlat/VPN QA]

Attachment: Sony Xperia XZ onboarding sheet in landscape mode

Comment 2

[Mike a [:mavduevskiy]]

Attachment: Bug 2043210 - Fix VPN bottom onboarding buttons in landscape mode

The onbaording card had all its content scrollable, so that in landscape
mode on phones with little width there was no space to render buttons.
This patch takes out buttons from the scrollable content, making sure
that they are always at the bottom.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8a3bba6b5331
https://hg.mozilla.org/integration/autoland/rev/e202f613cc4e
Fix VPN bottom onboarding buttons in landscape mode r=android-reviewers,jonalmeida

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e202f613cc4e

Comment 5

[Alexandra Martin [:alemartin], FxA/SubPlat/VPN QA]

Attachment: verified_video8.mp4

Fix verified using Fx Nightly 153.0a1 (Build #2016164674) with Google Pixel 7a (Android 16) and Sony Xperia XZ (Android 8). "Not now" and "Get started" onboarding sheet buttons are fixed now and displayed while in landscape mode.