Closed
Bug 2043256
Opened 5 months ago
Closed 5 months ago
Rename and clean-up functions to patch immediates in riscv64
Categories
(Core :: JavaScript Engine: JIT, task, P1)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
153 Branch
| Tracking | Status | |
|---|---|---|
| firefox153 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
(Blocks 1 open bug)
Details
Attachments
(2 external files)
ExtractLoad64ValueandUpdateLoad64Valuecan handleli_ptrandli_constantimmediates, butWriteLoad64Instructionsonly handlesli_ptrimmediates.ExtractLoad64Valuereadsli_ptrimmediates by callingjumpChainTargetAddressAt.- And
UpdateLoad64Valueupdatesli_ptrimmediates throughjumpChainSetTargetValueAt. patchMove32updatesImm32by callingpatchSub32FromStackPtr.
This is all confusing and makes the code harder to understand. Let's improve the function names and move related functions closer to each other.
| Assignee | ||
Comment 1•5 months ago
|
||
Changes:
- Add
{Load,Update,Write}LiPtrInstructionsto read/write toli_ptrinstructions. - Add
{Load,Update}LiConstantInstructionsto read/write toli_constantinstructions. - The actual operations are defined in the new classes
LiPtrandLiConstantto place
related functions next to each other.
| Assignee | ||
Comment 2•5 months ago
|
||
Add patchLi32 because it's confusing that patchMove32 calls
patchSub32FromStackPtr to modify the embedded immediate.
Updated•5 months ago
|
Severity: -- → N/A
Priority: -- → P1
Pushed by andre.bargull@gmail.com:
https://github.com/mozilla-firefox/firefox/commit/243edd188aa1
https://hg.mozilla.org/integration/autoland/rev/1071117b45fb
Part 1: Clean-up LiPtr and LiConstant instruction sequence methods. r=jandem
https://github.com/mozilla-firefox/firefox/commit/63a9bd8c47a6
https://hg.mozilla.org/integration/autoland/rev/dc4c88497499
Part 2: Add patchLi32 to modify Imm32 constants. r=jandem
Comment 4•5 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1071117b45fb
https://hg.mozilla.org/mozilla-central/rev/dc4c88497499
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox153:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Updated•4 months ago
|
QA Whiteboard: [qa-triage-done-c154/b153]
You need to log in
before you can comment on or make changes to this bug.
Description
•