2043307 - Crash in [@ __delayLoadHelper2 | _tailMerge_uiautomationcore.dll | mozilla::a11y::uiaRawElmProvider::RaiseUiaNotificationEvent]

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[Tracking Requested - why for this release]:

Started with Firefox 150.0.x with 800+ crashes from 500+ installs and continues with Firefox 151.

Crash report: https://crash-stats.mozilla.org/report/index/92e12178-ed0b-49c2-8192-45d040260528

Reason:

FACILITY_VISUALCPP / ERROR_PROC_NOT_FOUND

Top 10 frames:

0  KERNELBASE.dll  RaiseException
1  xul.dll  __delayLoadHelper2(ImgDelayDescr const*, long long (**)())  /builds/worker/workspace/obj-build/toolkit/library/build/D:/a/_work/1/s/src/vctools/delayimp/delayhlp.cpp:402
2  xul.dll  _tailMerge_uiautomationcore.dll
3  xul.dll  mozilla::a11y::uiaRawElmProvider::RaiseUiaNotificationEvent(mozilla::a11y::Ac...  accessible/windows/uia/uiaRawElmProvider.cpp:322
4  xul.dll  mozilla::a11y::PlatformAnnouncementEvent(mozilla::a11y::Accessible*, nsTSubst...  accessible/windows/msaa/Platform.cpp:175
4  xul.dll  mozilla::a11y::DocAccessibleParent::RecvAnnouncementEvent(unsigned long long ...  accessible/ipc/DocAccessibleParent.cpp:830
5  xul.dll  mozilla::a11y::PDocAccessibleParent::OnMessageReceived(IPC::Message const&)  ipc/ipdl/PDocAccessibleParent.cpp:1451
6  xul.dll  mozilla::dom::PContentParent::OnMessageReceived(IPC::Message const&)  ipc/ipdl/PContentParent.cpp:6770
7  xul.dll  mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecyc...  ipc/glue/MessageChannel.cpp:1798
7  xul.dll  mozilla::ipc::MessageChannel::DispatchMessage(mozilla::ipc::ActorLifecyclePro...  ipc/glue/MessageChannel.cpp:1724

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 2043307: Check whether UiaRaiseNotificationEvent is available before trying to call it. r?Morgan!

UiaRaiseNotificationEvent is only available on Windows 10 version 1709 and later.
Previously, we tried to call it without checking whether it was available, causing crashes on (very) outdated versions of Windows 10.
We now explicitly check whether this function is available before trying to call it, gracefully doing nothing if we can't.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/77f35c5ea88c
https://hg.mozilla.org/integration/autoland/rev/92e324a4a15b
Check whether UiaRaiseNotificationEvent is available before trying to call it. r=morgan

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/92e324a4a15b

Comment 4

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:Jamie, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox152 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Donal Meehan [:dmeehan]]

To add to comment 4, we could also take a release uplift request. If there are no concerns on risk.
The final planned dot release for Fx151 builds next week, so this will also have a week of bake time.

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Crashes on (very) outdated versions of Windows 10.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Simply disables an API call which isn't available on outdated versions of Windows 10. We have existing automated tests to ensure that the call still works on later Windows versions.
• String changes made/needed?: none
• Is Android affected?: no

Comment 7

[James Teh [:Jamie]]

Attachment: Bug 2043307: Check whether UiaRaiseNotificationEvent is available before trying to call it.

UiaRaiseNotificationEvent is only available on Windows 10 version 1709 and later.
Previously, we tried to call it without checking whether it was available, causing crashes on (very) outdated versions of Windows 10.
We now explicitly check whether this function is available before trying to call it, gracefully doing nothing if we can't.

Original Revision: https://phabricator.services.mozilla.com/D303249

Comment 8

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: Crashes on (very) outdated versions of Windows 10.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Simply disables an API call which isn't available on outdated versions of Windows 10. We have existing automated tests to ensure that the call still works on later Windows versions.
• String changes made/needed?: none
• Is Android affected?: no

Comment 9

[James Teh [:Jamie]]

Attachment: Bug 2043307: Check whether UiaRaiseNotificationEvent is available before trying to call it.

UiaRaiseNotificationEvent is only available on Windows 10 version 1709 and later.
Previously, we tried to call it without checking whether it was available, causing crashes on (very) outdated versions of Windows 10.
We now explicitly check whether this function is available before trying to call it, gracefully doing nothing if we can't.

Original Revision: https://phabricator.services.mozilla.com/D303249

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/2d91ec22bee3
https://hg.mozilla.org/releases/mozilla-release/rev/dd7660c114fa

Comment 11

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/e9ceb84c7f96
https://hg.mozilla.org/releases/mozilla-release/rev/8021a9cc35a3