2043329 - Text Fragments: Treat `<br>` as block boundary

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jan Jaeschke [:jjaschke]]

Attachment: minimal-testcase

Case 1: open the attached file, select the second "test", and hit "Copy Link to Highlight" in the context menu.

Expected Results: :~:text=test-,test
Actual Results: :~:text=testtest

Case 2: open the attached file, select both "test", hit "Copy Link to Highlight" in the context menu.
Expected Results: :~:text=test,test
Actual Results: :~:text=test%20test

Note that there is no whitespace between the first and second test, only a <br> element. The <br> is ignored, and the algorithm doesn't see a word boundary, and therefore treats these two words as one. If there is whitespace added (data:text/html,test<br> test), case 1 works, case 2 is still broken.

I believe the right way of fixing this is to treat <br> as a block boundary, which both allows the text before the <br> to be used as prefix, and which enforces range-based matching if the target range spans across a <br>.

Comment 1

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 2043329 - Text Fragments: Treat <br> as a block boundary for text directives. r=#dom-core!

Treat <br> as block-level in NodeHasBlockLevelDisplay so that text across
<br> is not concatenated.
Without this, the text directive for

foo<br>bar

would be :~:text=foobar, not :~:text=foo,bar.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3db4104a5f08
https://hg.mozilla.org/integration/autoland/rev/8e75d94753cb
Text Fragments: Treat <br> as a block boundary for text directives. r=dom-core-reviewers,smaug

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8e75d94753cb