2043423 - Add Windows shell infrastructure for setting a custom launcher icon for taskbar, start menu and desktop - and expose to scripting

Status: RESOLVED FIXED

(Firefox :: Shell Integration, enhancement, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

As it says on the tin - we'll go after shortcuts on the taskbar, start menu and desktop on Windows (since we know the installer tends to place them there) presuming the pathing matches the executable.

This is Windows-only for now.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 2043423 - Part 1: Add platform infrastructure for setting a custom launcher icon on Windows. r?nrishel

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 2043423 - Part 2: Add CustomIconManager module mechanism for setting a custom launcher icon. r?nrishel

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6e8e950cd6ef
https://hg.mozilla.org/integration/autoland/rev/3d624499a221
Part 1: Add platform infrastructure for setting a custom launcher icon on Windows. r=nrishel,win-reviewers
https://github.com/mozilla-firefox/firefox/commit/bcbeb188dc0f
https://hg.mozilla.org/integration/autoland/rev/6b0a1be931c0
Part 2: Add CustomIconManager module mechanism for setting a custom launcher icon. r=nrishel

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/01871f57554f
https://hg.mozilla.org/integration/autoland/rev/fbee3f5f6d81
Revert "Bug 2043423 - Part 2: Add CustomIconManager module mechanism for setting a custom launcher icon. r=nrishel" for causing build bustages @ WinTaskbar.cpp

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages @ WinTaskbar.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/fbee3f5f6d81ecb2032fe3ceda6abb1fa61fd7bb

Push with failures

Failures log ->ERROR - /builds/worker/checkouts/gecko/widget/windows/WinTaskbar.cpp(69,18): error: use of undeclared identifier 'MakeScopeExit'; did you mean 'mozilla::MakeScopeExit'?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9c882ebc056b
https://hg.mozilla.org/integration/autoland/rev/6890faf6f16f
Part 1: Add platform infrastructure for setting a custom launcher icon on Windows. r=nrishel,win-reviewers
https://github.com/mozilla-firefox/firefox/commit/445a980aea97
https://hg.mozilla.org/integration/autoland/rev/942ec841badc
Part 2: Add CustomIconManager module mechanism for setting a custom launcher icon. r=nrishel

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6890faf6f16f
https://hg.mozilla.org/mozilla-central/rev/942ec841badc