2043607 - Use the engine id rather than engine name in the address bar code

Status: NEW

(Firefox :: Address Bar, task, P3)

Description

[Mark Banner (:standard8)]

The address bar code currently uses the search engine name when keeping track of search engines in results and payloads. We would like to change this to use the search engine identifier instead. This follows recent work on other areas, and also changes within the search service over the last few years to start preferring ids more than the name.

One reason is that the identifier is more stable, we do not need to worry about if the search engine is renamed. An additional reason is that the lookup for the identifier is a map index, rather than having to iterate over the entries of the map. Whilst this won't significantly improve performance in most cases, it would still be good to tidy up.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 2043607 - Use engine id instead of name for urlbar searchMode. r?#urlbar-reviewers!

Renames UrlbarQueryContext.searchMode.engineName to searchMode.engineId and makes the appropraite changes.

Renaming a custom engine in settings (or via configuration updates) will no longer exit search mode.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 2043607 - Use engine id in urlbar result payloads and DOM data attributes r?#urlbar-reviewers!