Closed
Bug 2043944
Opened 5 months ago
Closed 5 months ago
Sports widget - Upcoming matches alone should not be used to determine kick-off
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
153 Branch
| Tracking | Status | |
|---|---|---|
| firefox153 | --- | fixed |
People
(Reporter: rhamoui, Assigned: rhamoui)
References
(Blocks 1 open bug)
Details
Attachments
(1 external file)
We currently have a variable in place that determines if kick-off has started, and that includes if upcoming matches has data in it.
Upcoming matches should not be used to determine if kick-off has started, as it can show up to 21 days BEFORE kick-off.
Previous games or live games should determine kick-off instead
| Assignee | ||
Comment 1•5 months ago
|
||
Updated•5 months ago
|
Assignee: nobody → rhamoui
Status: NEW → ASSIGNED
Pushed by rhamoui@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/0cf01064a4a4
https://hg.mozilla.org/integration/autoland/rev/f359429e3557
Remove upcoming games from determining if the kick-off has started. r=nina-py
Pushed by asilaghi@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/5bfc85feae3e
https://hg.mozilla.org/integration/autoland/rev/57d64fedbbb6
Revert "Bug 2043944 - Remove upcoming games from determining if the kick-off has started. r=nina-py" for causing node failures
Comment 4•5 months ago
|
||
Backed out for causing node failures
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | bundles | Activity Stream bundle out of date
Flags: needinfo?(rhamoui)
Pushed by rhamoui@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/773af34ba11b
https://hg.mozilla.org/integration/autoland/rev/0b1cff8da2f0
Remove upcoming games from determining if the kick-off has started. r=nina-py
Comment 6•5 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox153:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Updated•5 months ago
|
Blocks: live-tournament-trainhop
| Assignee | ||
Updated•5 months ago
|
Flags: needinfo?(rhamoui)
Updated•4 months ago
|
QA Whiteboard: [qa-triage-done-c154/b153]
You need to log in
before you can comment on or make changes to this bug.
Description
•