Closed Bug 2043952 Opened 5 months ago Closed 5 months ago

Add disambiguation comment to menu-view-open-tabs Fluent string

Categories

(Firefox :: Sidebar, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
153 Branch
Tracking Status
firefox153 --- fixed

People

(Reporter: dr.seed.lu, Assigned: dr.seed.lu, Mentored)

References

Details

Attachments

(1 external file)

Follow-up to bug 2039294 / D301981.

After D301981 landed, :flod left a comment that the new
menu-view-open-tabs string in browser/locales/en-US/browser/sidebar.ftl
needs the same "Open tabs" disambiguation comment that the other Open
Tabs strings already have, so translators know "Open Tabs" here is a
noun phrase (the tabs that are open), not an instruction to open tabs.

Current (sidebar.ftl line 11):

Label for the Open Tabs entry in the View > Sidebars menu bar menu.

menu-view-open-tabs =
.label = Open Tabs

The updated version will be:

Label for the Open Tabs entry in the View > Sidebars menu bar menu.

"Open Tabs" is a noun phrase referring to the tabs currently open in

the browser, not an instruction to open tabs.

menu-view-open-tabs =
.label = Open Tabs

Same comment style is already used on sidebar-menu-open-tabs-label
and sidebar-opentabs-title. I am only adding a comment, no code changes required.
I am filing as a small follow-up since 2039294 is already closed.

Mentor: kcochrane, nsharpley

Follow-up to bug 2039294 / D301981.

After D301981 landed, :flod left a comment that the new
menu-view-open-tabs string in browser/locales/en-US/browser/sidebar.ftl
needs the same "Open tabs" disambiguation comment that the other Open
Tabs strings already have, so translators know "Open Tabs" here is a
noun phrase (the tabs that are open), not an instruction to open tabs.

Current (sidebar.ftl line 11):

  # Label for the Open Tabs entry in the View > Sidebars menu bar menu.
  menu-view-open-tabs =
    .label = Open Tabs

The updated version will be:

  # Label for the Open Tabs entry in the View > Sidebars menu bar menu.
  # "Open Tabs" is a noun phrase referring to the tabs currently open in
  # the browser, not an instruction to open tabs.
  menu-view-open-tabs =
    .label = Open Tabs

Same comment style is already used on sidebar-menu-open-tabs-label
and sidebar-opentabs-title. Comment addition only, no code change.

I am filing as a small follow-up since 2039294 is already closed.

flod left a comment on D301981 noting the new menu-view-open-tabs string
is missing the same "Open tabs" disambiguation comment the other Open
Tabs strings carry, so translators know "Open Tabs" is a noun phrase
(the tabs currently open) and not an instruction.

Same pattern as sidebar-menu-open-tabs-label and sidebar-opentabs-title.
Just a comment addition.

Assignee: nobody → dr.seed.lu
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Blocks: 2039294
Pushed by flodolo@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/9bb724a381b0 https://hg.mozilla.org/integration/autoland/rev/080163a50674 Add disambiguation comment to menu-view-open-tabs Fluent string r=flod,fluent-reviewers DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
QA Whiteboard: [qa-triage-done-c154/b153]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: