2044098 - reuse chatbot keyboard shortcut for smart window assistant sidebar

Status: VERIFIED FIXED

(Core :: Machine Learning: Frontend, enhancement)

Description

[Ed Lee :Mardak]

ai-chatbot-sidebar-shortcut key = X is used on win/linux as alt-ctrl-x and ctrl-x on macos from bug 1905027

https://searchfox.org/firefox-main/rev/e28b34ab33dbf49364999070168cbb7e11e8e5bd/browser/base/content/browser-sets.inc.xhtml#297-303

chatbot is disabled in smart window with bug 2003054, so we can reuse its shortcut for toggling assistant sidebar

Comment 1

[:omarg]

Attachment: Bug 2044098 - Enable Smart Window sidebar toggle keybind

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1c91f6582e5a
https://hg.mozilla.org/integration/autoland/rev/ff02e714daec
Enable Smart Window sidebar toggle keybind r=yjamora

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/ff02e714daec

Comment 4

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: Normalizes behavior between Smart Window and Classic Window sidebars.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: key = X is used on win/linux as alt-ctrl-x and ctrl-x on macos,
  keybinding should work for both Classic Window chat sidebar and Smart Window assistant sidebar
• Risk associated with taking this patch: low
• Explanation of risk level: Adds keybinding support only in Smart Window
• String changes made/needed?: none
• Is Android affected?: no

Comment 5

[:omarg]

Attachment: Bug 2044098 - Enable Smart Window sidebar toggle keybind

Original Revision: https://phabricator.services.mozilla.com/D304155

Comment 6

[Ciprian Georgiu, Desktop QA]

This issue is verified as fixed on latest Beta 153.0b1 with Win 11, macOS 26 and Ubuntu 26.04.

Comment 7

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/7c069b004390
https://hg.mozilla.org/releases/mozilla-release/rev/3b6f4ec43f8d

Comment 8

[Ciprian Georgiu, Desktop QA]

This is also verified as fixed on Firefox 152.0.2 with macOS 26, Win 11 and Ubuntu 26.