2044131 - Add browser.ipProtection.bandwidth.enabled prefs to allowed prefs for feature callout CTA

Status: RESOLVED FIXED

(Firefox :: IP Protection, task)

Description

[Becca]

In the future, we will want to be able to set the browser.ipProtection.bandwidth.enabled pref in a feature callout CTA. In order to do this, we need to add the pref to the allowedPrefs list here: https://searchfox.org/firefox-main/rev/e28b34ab33dbf49364999070168cbb7e11e8e5bd/toolkit/components/messaging-system/lib/SpecialMessageActions.sys.mjs#311

Comment 1

[Becca]

Attachment: Bug 2044131 - Add browser.ipProtection.bandwidth.enabled pref to allowed prefs for feature callout CTA - r=#ip-protection-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1993cf2f5870
https://hg.mozilla.org/integration/autoland/rev/e4f9cbec7226
Add browser.ipProtection.bandwidth.enabled pref to allowed prefs for feature callout CTA - r=omc-reviewers,emcminn

Comment 3

[Becca]

Attachment: Bug 2044131 - Add browser.ipProtection.bandwidth.enabled pref to allowed prefs for feature callout CTA -

Original Revision: https://phabricator.services.mozilla.com/D303900

Comment 4

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Needed in order to set a pref on a CTA being added in a feature callout via experimenter in 151.0.4
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: low
• Explanation of risk level: Very low risk, simply adds a pref to the list of prefs that are allowed to be set by special message actions
• String changes made/needed?: None
• Is Android affected?: no

Comment 5

[Becca]

Attachment: Bug 2044131 - Add browser.ipProtection.bandwidth.enabled pref to alowed prefs for feature callout CTA -

Comment 6

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: Needed in order to use SET_PREF to set a preference with a feature callout CTA being added via experimenter in 151.0.4
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: low
• Explanation of risk level: Very low risk, only adds pref to the list of prefs that are allowed to be set by special message actions
• String changes made/needed?: None
• Is Android affected?: no

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e4f9cbec7226

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/5f1e73d4c0c0
https://hg.mozilla.org/releases/mozilla-beta/rev/9f3785b9ecb8